Bug 71516 - Konqueor in combination with fish fail to open certain files
Summary: Konqueor in combination with fish fail to open certain files
Status: RESOLVED DUPLICATE of bug 124938
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: fish (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Jörg Walter
URL:
Keywords:
: 88042 89296 94946 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-12-30 19:37 UTC by Thomas Zander
Modified: 2006-11-04 18:25 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
failing file. (91 bytes, text/plain)
2004-11-22 10:35 UTC, Thomas Zander
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander 2003-12-30 19:37:46 UTC
Version:           3.1.94 (using KDE 3.1.94 (CVS >= 20031206), compiled sources)
Compiler:          gcc version 3.3.2 (Debian)
OS:          Linux (i686) release 2.6.0dell-optiplex

MiddleMouseButton-click on a file which exists on a remote machine (via (ssh) fish) will open it in (for example) kwrite.
The normally goes well; unless the remote file is smaller then some 1000 bytes, then the protocol freezes and I have to press the cancel button on the progress dialog for it to show (yes it actually shows the file after a cancel).

I could only reproduce this by MMB clicking on a file in konqueror; some investigation shows that the server on the remove end is started 3 times in less then 5 seconds, so my guess is some race condition...
Comment 1 J 2004-01-21 19:44:02 UTC
Hallo Jörg,
if you are maintaining fish please be also aware that it is not LFS clean. Instead of using "int" please use "KIO::filesizt_t" and "KIO::fileoffset_t" unfortunately fish also uses values of -1 as flags, better define something like "FISH::nowhere" as "(unsingned long long)(-1)".

Please consider the following trivial patch to make fish display the size of long files correctly:

diff fish.cpp fish.cpp.old
894c894
<                     atom.m_long = line.mid(1).toLongLong(&isOk);
---
>                     atom.m_long = line.mid(1).toInt(&isOk);

The little patch does not correct most of the LFS issues, but is better than nothing. I also had a lock at the other problems, but if I would fix them that would result in a partial rewrite of fish.

Yours Jürgen
Comment 2 Eric Martel 2004-07-30 19:59:37 UTC
As for me, the problem occurs as soon as I wish to transfer a file <1k from the remote location and, unlike Mr. Zander, pressing the cancel button won't make it appear on my side (actually, a .part is created during the transfer but it is erased after I press cancel).

I have KDE 3.2.3 on Mandrake Cooker.

I found a thread on this for SuSE:
http://lists.suse.com/archive/suse-linux-e/2004-Jul/3311.html

And here is a screenshot I took of a stalled dialog box:
http://vid.ericmartel.net/fish_stalled.png
Comment 3 Ulf Norén 2004-08-01 22:39:39 UTC
I don't have much more to add than that I have the same problem.
A file with 1024 bytes hang but with 1025 bytes it opens normally.

I'm running a week old compile of the sources from CVS.

/Ulf
Comment 4 Christoph Cullmann 2004-08-26 22:52:20 UTC
*** Bug 88042 has been marked as a duplicate of this bug. ***
Comment 5 Martin Bernreuther 2004-09-02 07:18:25 UTC
Similar to Bug 87109?
http://bugs.kde.org/show_bug.cgi?id=87109
(Which seems to be already fixed)

I have the same problems here with a SuSE 9.1
installation using the actual SuSE KDE 3.3.0
supplement binaries. Copying files <=1024 bytes
(drag&drop from a fish: to a local konqueror directory)
hangs after the data is transferred, waiting for more data...

With sftp: and smb: this problem doesn't seem to occur.
Comment 6 Oliver Jusinger 2004-09-05 00:18:15 UTC
Same problem here: current debian unstable, Kernel 2.6.8, KDE 3.3
(I really love fish:// and use it quite often for transfers)
Comment 7 Maksim Orlovich 2004-09-24 17:37:27 UTC

*** This bug has been marked as a duplicate of 87109 ***
Comment 8 Andrés 2004-10-14 04:23:21 UTC
I have the same problem. 
This is then a fish problem?
Ok, I just resolved it partially modifying the value "1024" of the mimeBuffer to "1" (Now I cannot copy files smallers than 1 byte, Who have files smallers than 1 byte?? :P).
It is changing the all "1024" values for "1". But that solution is not optimized, of course.
I think that fish must be optimized. Some comments in there and some things not already finished.

Byes.
Comment 9 Cyrille Dunant 2004-11-16 11:47:55 UTC
In today's CVS (16 11. 04) the bug still appears. So perhaps it should not be closed...
Comment 10 Thomas Zander 2004-11-22 10:32:19 UTC
This bug still (partly) exists in current CVS. Reopening.

I noticed the problem with several different files; but I also noticed at least one file that was 705b and opened correctly.
I'll attach one file that had this problem.
Comment 11 Thomas Zander 2004-11-22 10:35:12 UTC
Created attachment 8363 [details]
failing file.

Note that I cleaned out the content of this file for privacy purposes but
making it smaller had no change in fish's incapability to handle the file.
Growing the file to larger then 1Kb was the only way to get it copied
correctly.
Comment 12 Nicolas Goutte 2005-09-17 23:52:33 UTC
For large files (>2GB) see bug #79573
Comment 13 Nicolas Goutte 2005-09-17 23:55:45 UTC
See also bug #89296 (probably a duplicate)
Comment 14 Nicolas Goutte 2005-09-18 00:59:18 UTC
*** Bug 89296 has been marked as a duplicate of this bug. ***
Comment 15 Nicolas Goutte 2005-09-18 02:37:40 UTC
*** Bug 94946 has been marked as a duplicate of this bug. ***
Comment 16 Martin Koller 2006-11-04 18:25:24 UTC
I think this is the same as #124938 as I can no longer reproduce it with the fix I made today.

*** This bug has been marked as a duplicate of 124938 ***