Bug 70343 - View Source does not display russian message source correctly
Summary: View Source does not display russian message source correctly
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: GUI (show other bugs)
Version: 1.5.94
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 73068 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-12-13 21:46 UTC by Roman Shiryaev
Modified: 2007-09-14 12:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Shiryaev 2003-12-13 21:46:23 UTC 
Version:           1.5.94 (using KDE KDE 3.1.94)
Installed from:    Compiled From Sources
Compiler:          gcc (GCC) 3.3.1 (Mandrake Linux 9.2 3.3.1-2mdk) 
OS:          Linux

In stable kmail 1.5.{3,4} I haven't this problem. 
But since i use kde 3.2 beta1 and 3.2 beta2 I can't view cyrillic letter in 'view source' at all, it doesn't depend of message 
Content-Type: text/plain;
  charset=koi8-r

the same if charset is utf8 or windows-1251

See screenshot http://rmn-sh.nm.ru/kmail-bug.jpg
There are correct message content at background and wrong in front of it in the 'view source' window.
Comment 1 Thiago Macieira 2003-12-13 22:31:36 UTC 
Confirmed. But I don't know if this is a bug or a feature.
Comment 2 Tommi Tervo 2004-01-20 22:34:12 UTC 
*** Bug 73068 has been marked as a duplicate of this bug. ***
Comment 3 khadhi soon 2004-03-03 02:15:19 UTC 
Bug 76482: kmail does not display the language of
Asia here ("View->View Source"). 

http://bugs.kde.org/show_bug.cgi?id=76482

Please check it out.

I think , resolve your problem.
Comment 4 Roman Shiryaev 2004-03-03 11:53:49 UTC 
Thanks. I've rebuilt kdepim and it's all right now (: I'm glad.
Comment 5 Nick Shaforostoff 2004-03-17 20:59:01 UTC 
so, mark as duplicate of #76482 and wait for KMail developers to apply patch?
Comment 6 Roman Shiryaev 2004-06-24 01:22:16 UTC 
I have also noticed that search function doesn't work (it doesn't find anything) if search request is "body contains" "any cyrillic text"

So It's important problem.
Comment 7 Till Adam 2004-06-25 10:06:22 UTC 
CVS commit by tilladam: 

Use the right codec instead of latin1 when showing the source of mails.

Patch by Toyohiro Asukai <toyohiro@ksmplus.com>. Thanks a lot.

CCMAIL: 70343-done@bugs.kde.org
CCMAIL: 76482-done@bugs.kde.org


  M +3 -1      kmcommands.cpp   1.155


--- kdepim/kmail/kmcommands.cpp  #1.154:1.155
@@ -617,5 +617,7 @@ KMCommand::Result KMShowMsgSrcCommand::e
 {
   KMMessage *msg = retrievedMessage();
-  QString str = QString::fromLatin1( msg->asString() );
+  QString str = QTextCodec::codecForName(  msg->charset().isEmpty() ?
+                QCString( kmkernel->networkCodec()->mimeName() ) :
+                msg->charset() )->toUnicode( msg->asString() );
 
   MailSourceViewer *viewer = new MailSourceViewer(); // deletes itself upon close