Bug 69635 - Full screen mode changes X resolution, but does not recenter window
Summary: Full screen mode changes X resolution, but does not recenter window
Status: RESOLVED FIXED
Alias: None
Product: krdc
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Urs Wolfer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-04 19:16 UTC by Oded Arbel
Modified: 2007-07-23 22:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oded Arbel 2003-12-04 19:16:22 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.3.1 
OS:          Linux

Note: I have kicker configured with a top panel in addition to te bottom panel. neither is hidden or allows windows to overlap it.

When clicking "full screen", the X resolution changes, but the window is not centered so if the window is not at the top left of the screen then its title can be viewed, and the top kicker panel can be seen as well.

In addition to that, the virtual desktop stays the same size, so I can move the mouse pointer around and reach the other part of the desktop, including changing desktops in the pager, calling other applications, etc'.
Comment 1 James 2004-01-24 03:15:54 UTC
Confirmed with KDE 3.2 RC1, default panel setup.  If this can't be fixed for KDE 3.2 final I suggest temporarily removing the fullscreen button because it really doesn't work as advertised.
Comment 2 tim 2004-01-24 03:49:15 UTC
I have no idea how to reproduce it with a default panel (and it is using Qt for fullscreen).
Comment 3 Oded Arbel 2004-01-25 08:10:52 UTC
I've reproduced it with the default panel:
- open a remote desktop with a resolution smaller then your current X
- click full screen
- the window decoration of the krdc window is visible at the top of the screen.

What should happen:
The screen should be centered on the content of the krdc window so that no window border or decoration should be visible.

Also, its then possible to use the mouse to navigate the "real view" to other parts of the X's "virtual desktop", something that wasn't possible in 3.1. this could get very anoying real fast when I need to get to parts of the remote desktop that are close to the edges of the desktop, such as a windows "start" button.

** besides, its very easy to create a child panel and put it on top, even just for the test. it doesn't even need to have anything in it. its not like its a very uncommon configuration. the child panel just a magnifies the problems - it manifests itself clearly even in default configurations.
Comment 4 tim 2004-01-26 02:46:45 UTC
After upgrading everything I can reproduce this. But since the update some non-KDE apps have the same problem (I had it with a game running under WineX), so it's probably a KWin issue.
Comment 5 Oded Arbel 2004-01-26 10:04:20 UTC
Can you at least please mark this bug as confirmed ?
Comment 6 Lubos Lunak 2004-01-26 19:01:56 UTC
It's simple: Either let the window manager handle making the window fullscreen, or do it yourself, but don't try clever mixtures. If you comment out forcing maximum size in krdc.cpp, it will work fine. KWin denies fullscreening for windows that have maximum size set, because it possibly couldn't fullfill it anymore e.g. after resolution change using XRANDR.
In fact, if I understand correctly that krdc grabs the input anyway, and uses the vidmode extension for changing resolutions, I suggest you do the fullscreening yourself using WX11BypassWM window. Window managers can't make their managed fullscreen windows follow resolution changes done using vidmode due to its limitations (and I think it wouldn't be a good thing to do even if that was possible).
Comment 7 tim 2004-01-28 18:39:24 UTC
I experimented with it, but just commenting out the maximum size for the fullscreen does not work. The problem is the same top-level widget is used both in window'd mode and in fullscreen, and for the window'd mode I need the maximum size, so there is always a maximum size set. Is there a way to remove a widget's maximum size? I can't find one.

Comment 8 Lubos Lunak 2004-01-29 14:27:39 UTC
See the last comment in bug #73509.
Comment 9 Urs Wolfer 2007-07-23 22:52:45 UTC
SVN commit 691520 by uwolfer:

Move the almost rewritten KRDC (Google Summer of Code project) back to trunk.

Discussed on release team mailing list.

The following issues are resolved with the new version. More issues should be resolved too, but they need some more review. If you have again a problem, please open a new bug report.

#49970: Fullscreen doesn't work with xinerama
#59026: Synchronize KRDC with LibVNCClient
#69635: Full screen mode changes X resolution, but does not recenter window
#69636: closing KRDC while in full screen mode does not restore the screen
#74767: redraw problems with krdc
#116934: report bug entry missing
#121146: window title should include host connection type
#123346: Dock icons not themeable
#127002: Enhancement request: Add Desktop number for storing passwords in kdewallet for vnc connections 
#127034: can not send esc keystroke to remote machine inside krdc
#132367: kwallet integration only stores the password, username needed as well for some viewers
#136049: RFE: use tabbed interface
#136462: Password in link ignored
#137141: do not send current unix username to server
#137182: turning fullscreen changes resolution, not the window size
#141783: krdc doesn't works with --fullscreen option
#146210: keystrokes are poorly transferred

BUGS: 49970, 59026, 69635, 69636, 74767, 116934, 121146, 123346, 127002, 127034, 132367, 136049, 136462, 137141, 137182, 141783, 146210

 A             krdc (directory)   branches/work/soc-krdc/krdc#691519