Bug 69074 - konqueror: sizing error in framesets - off by one pixel
Summary: konqueror: sizing error in framesets - off by one pixel
Alias: None
Product: konqueror
Classification: Applications
Component: khtml renderer (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
Depends on:
Reported: 2003-11-26 15:31 UTC by Christian Boltz
Modified: 2006-03-13 01:50 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

testcase showing the off-by-one problem (38.90 KB, application/octet-stream)
2005-10-29 21:59 UTC, Christian Boltz

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Boltz 2003-11-26 15:31:11 UTC
Version:            (using KDE KDE 3.1.93)
Installed from:    SuSE RPMs
OS:          Linux

Konqueror has a off-by-one pixel problem when rendering framesets.

To see the bug, go to http://www.wein-vin-vinum.net/home.php and change Konqueror's window height (and width) slowly. You'll notice that the left image will not match the bottom image with every second pixel window size.
The outer frameset (everything except the black "border") has fixed width and height, also the left, top and bottom inner frames, given in pixels.

This problem exists with horicontal and vertical direction, but the horicontal one can be seen clearer on my page.
Comment 1 Christian Boltz 2004-05-31 13:22:19 UTC
The problem still appears in KDE 3.2.2 (on SuSE 9.1)
Comment 2 Thomas Zell 2004-08-12 19:53:03 UTC
KDE 3.3.0 RC shows the same behaviour.
Comment 3 Germain Garand 2005-10-29 01:12:19 UTC
"Unknown host http://www.wein-vin-vinum.net/home.php"

Though this is most probably still valid. 
Maksim, if you ever happen to read this, what's your sentiment about the frame patch that was recently contributed to WebCore?
Comment 4 Maksim Orlovich 2005-10-29 03:23:48 UTC
My sentiment on that is this: I know it should fix bug #60113 (I actually sort of directed the author of the patch to the issue by showing that report), but I basically do not know enough to evaluate it, and don't have the time to brute-force test. I guess bug #101753 is related, too.

P.S.: I read kde-bugs-dist, so I see virtually everything konq-related..
Comment 5 Germain Garand 2005-10-29 04:18:16 UTC
OK. So that's a nice fix but can be postponed a bit, AFAICS ... mostly a matter of finding the time to delve into the algorithm for some hours ;(
Comment 6 Christian Boltz 2005-10-29 21:57:58 UTC
Sorry that the page showing this bug is not reachable.

I'll append a testcase.war file with an example (actually, it's from my local copy of the page, but reduced to the base components).

BTW: I can reproduce the problem with KDE 3.4.2 on SUSE Linux 10.0
Comment 7 Christian Boltz 2005-10-29 21:59:18 UTC
Created attachment 13212 [details]
testcase showing the off-by-one problem
Comment 8 Christian Boltz 2005-12-23 21:53:05 UTC
Still reproduceable in KDE 3.5
Comment 9 Germain Garand 2006-03-13 01:50:09 UTC
SVN commit 518068 by ggarand:

apply nice frame calculation enhancements patch
by Niels Leenheer <niels.leenheer@gmail.com>

cf. WC/3587

also, be extra careful not to apply complex masks to frames
in KHTMLView::drawContents.

BUG: 60113, 69074, 101753

 M  +8 -5      khtmlview.cpp  
 M  +1 -2      rendering/render_form.cpp  
 M  +141 -27   rendering/render_frames.cpp