Bug 68483 - MSN unable to connect with Konqueror offline browsing mode
Summary: MSN unable to connect with Konqueror offline browsing mode
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: http (show other bugs)
Version: SVN
Platform: Mandrake RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-18 09:16 UTC by Tom Gilligan
Modified: 2004-06-24 22:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Gilligan 2003-11-18 09:16:02 UTC
Version:           0.7.93 (using KDE KDE 3.1.3)
Installed from:    Mandrake RPMs
Compiler:          gcc 3.3.1 
OS:          Linux

When konqueror is set to offline browsing mode, Kopete can not connect to MSN.
A message something along the lines of 'Could not find file "http://loginnet.passport.com etc etc"'
Comment 1 Olivier Goffart 2003-11-18 21:38:10 UTC
aaah, that's why, the Konqueror's offline mode.

I'll see what i can do.
Comment 2 Matt Rogers 2003-11-18 22:35:08 UTC
why would konqueror's offline mode affect anything in kopete?
Comment 3 Olivier Goffart 2003-11-18 22:44:34 UTC
Bacause MSN use KIO::get to get the encrypted password to send trought the msn socket. (it's via ssl and https)

Comment 4 Matt Rogers 2003-11-18 22:59:34 UTC
and so with konqueror in offline mode, KIO::get won't go out to the internet for anything? That seems rather stupid (from my POV, since Konq isn't the only one using KIO::get) and would seem to be like an kio or konqueror bug instead. (Which we should of course workaround until it actually gets fixed)
Comment 5 Olivier Goffart 2003-12-04 13:27:21 UTC
I need the help of someone which knows KIO.

I already tried this without succes
job->addMetaData("cache", "reload");
job->addMetaData("no-cache", "true");	

It's not possible to get KIO::get downloading something if konqueror is in offline mode. 
Comment 6 Olivier Goffart 2004-01-01 22:13:47 UTC
Setting to low priority, it's not verry important.

I've absolutely no idea how to fix it, i need some help.
Comment 7 Olivier Goffart 2004-06-09 22:53:40 UTC
I've tried everything, but i can't get it works.
it's probably a bug in kio or somewere in kdelibs.
Comment 8 Matt Rogers 2004-06-09 23:00:17 UTC
resetting priorities from the ones we used in kopete (as an FYI)
Comment 9 Dawit Alemayehu 2004-06-24 07:51:56 UTC
This is not a bug in kio. It is an issue in kio_http. I do not know what Waldo intended with the "no-cache" meta-data since it is not directly used in kio_http. However, setting the "cache"  meta-data to "reload" should work fine. Can one of you kopete developers enable the debug area for kio_http (7103/7113) and see if the data comes from the cache even when you send the above meta-data ? You should see the following statement in the debug output:

"readBody: read data from cache!"...
Comment 10 Waldo Bastian 2004-06-24 10:33:43 UTC
Setting "no-cache" makes no sense at all, it is only used by kio_http to report back to the application the caching directive sent by the web-server.

job->addMetaData("cache", "reload") should work just fine though.
Comment 11 Olivier Goffart 2004-06-24 22:34:13 UTC
CVS commit by ogoffart: 

Fix the Bug 68483 (MSN unable to connect with Konqueror offline browsing mode)

It seems it didn't work because I forgot I had to insert meta data it twice :-s

Anyway, i still think than the message "The file or folder [url] doesn't exist" is not the correct message to show, even in konqueror.

CCMAIL: 68483-done@bugs.kde.org


  M +3 -6      msnnotifysocket.cpp   1.143


--- kdenetwork/kopete/protocols/msn/msnnotifysocket.cpp  #1.142:1.143
@@ -281,10 +281,6 @@ void MSNNotifySocket::parseCommand( cons
                         KIO::Job *job = KIO::get( KURL( authURL ), true, false );
                         job->addMetaData("cookies", "manual");
-                        /* FIXME: This should force kio to download the page even is we are in the
-                         * konqueror offline mode.  But it does not seems to have any effect
-                         * [see bug #68483]
+                        // This should force kio to download the page even is we are in the konqueror offline mode.  [see bug #68483]
                         job->addMetaData("cache", "reload");
-                        job->addMetaData("no-cache", "true");
-                         */
                         QObject::connect( job, SIGNAL(result( KIO::Job *)), this, SLOT(slotAuthJobDone( KIO::Job *)) );
                 }
@@ -325,9 +321,9 @@ void MSNNotifySocket::parseCommand( cons
                 if( c )
                 {
-                        c->setOnlineStatus( convertOnlineStatus( data.section( ' ', 0, 0 ) ) );
                         QString publicName=unescape( data.section( ' ', 2, 2 ) );
                         if (publicName!=c->property( Kopete::Global::Properties::self()->nickName()).value().toString())
                                 changePublicName(publicName,c->contactId());
                         c->setObject( unescape(data.section( ' ', 4, 4 )) );
+                        c->setOnlineStatus( convertOnlineStatus( data.section( ' ', 0, 0 ) ) );
                 }
         }
@@ -623,4 +619,5 @@ void MSNNotifySocket::slotAuthJobDone ( 
                 job->addMetaData("cookies", "manual");
                 job->addMetaData("setcookies", cookies);
+                job->addMetaData("cache", "reload");
 
                 QObject::connect( job, SIGNAL(data( KIO::Job *,const QByteArray&)), this, SLOT(slotAuthJobDataReceived( KIO::Job *,const QByteArray&)) );