Bug 67520 - KNode doesn't save panes dimension between sessions
Summary: KNode doesn't save panes dimension between sessions
Status: RESOLVED WORKSFORME
Alias: None
Product: knode
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: HI normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 17834 66111 67690 68233 71320 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-11-07 18:40 UTC by Davide Ferrari
Modified: 2004-03-13 20:49 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Davide Ferrari 2003-11-07 18:40:13 UTC
Version:            (using KDE KDE 3.1.93)
Installed from:    Compiled From Sources
OS:          Linux

Simply do not save size of panes. I got the three panes in an horizontal way and everytime I launch KNode the first two are too small, I resize them, then I close KNode, relaunch it and they are again small.
Comment 1 Roberto Selbach 2003-11-10 14:40:15 UTC
*** Bug 67690 has been marked as a duplicate of this bug. ***
Comment 2 Heinrich Wendel 2003-11-10 14:59:47 UTC
yeah this is really ugly, worked in kde 3.1
Comment 3 Roberto Selbach 2003-11-14 20:49:49 UTC
*** Bug 68233 has been marked as a duplicate of this bug. ***
Comment 4 Andre Woebbeking 2003-11-29 13:37:19 UTC
I can confirm this. 

In the dtor of KNMainWindow saveMainWindowSettings() is called, but i can't find a call of applyMainWindowSettings() in that class.
Comment 5 Stephan Binner 2003-11-30 22:21:59 UTC
*** Bug 17834 has been marked as a duplicate of this bug. ***
Comment 6 Stephan Binner 2003-11-30 22:22:33 UTC
*** Bug 66111 has been marked as a duplicate of this bug. ***
Comment 7 Stephan Binner 2003-12-06 16:42:35 UTC
Subject: kdepim/knode

CVS commit by binner: 

Restore previous windows size
CCMAIL: 67520-done@bugs.kde.org


  M +2 -0      knode.cpp   1.125


--- kdepim/knode/knode.cpp  #1.124:1.125
@@ -51,4 +51,6 @@ KNMainWindow::KNMainWindow( QWidget* pWi
   setCentralWidget( m_mainWidget );
   createGUI( "knodeui.rc" );
+
+  applyMainWindowSettings(KGlobal::config(),"mainWindow_options");
 }
 


Comment 8 Ismail Donmez 2003-12-06 16:48:59 UTC
Now only left bug is it does not save slider positions. But guess thats for another bug .
Comment 9 Stephan Binner 2003-12-06 17:02:48 UTC
What sliders? The pane layout is saved and restored here.
Comment 10 Ismail Donmez 2003-12-06 17:41:27 UTC
Pane layout does not seem to get saved here.
Comment 11 Andreas Hartmann 2003-12-06 23:27:14 UTC
Subject: Re:  KNode doesn't save panes dimension between sessions

Same problem here. The size of the window with the newsgroups on the left 
side seems to be safed, but not the size of knode as whole.
'Seems' means:
The size of the left window with the newsgroups is not safed correctly, if 
the the window from knode is changed afterwards.
The size is only safed, if the window size of the whole knode window is 
not changed.

Comment 12 Stephan Binner 2003-12-07 11:31:15 UTC
Please use current CVS, including kdelibs, (newer than Beta 2) before commenting if this bug still exists after the day of commit/report closure.
Comment 13 Andreas Hartmann 2003-12-07 18:20:47 UTC
Subject: Re:  KNode doesn't save panes dimension between sessions

I have actual CVS code (from bluemchen) from today but the problem exists 
as I mentioned above. Sorry.

Which libraries should be new?

Comment 14 Davide Ferrari 2003-12-07 19:31:33 UTC
I can confirm, just emerged kdelibs and kdenetwork from today's CVS and the problem is still there. Maybe do I have to delete previous knoderc file?
Comment 15 Stephan Binner 2003-12-09 10:38:56 UTC
Please move away your knoderc or try with a new user. Perhaps some old leftover?
Comment 16 Ismail Donmez 2003-12-09 15:24:54 UTC
Doesnt work with a new user either. On cvs-head.
Comment 17 Davide Ferrari 2003-12-09 15:26:57 UTC
Yes, same happens here. It's still broken :(
Comment 18 Davide Ferrari 2003-12-09 18:52:03 UTC
Ok, as KDE-CVS of 9th december the bug seems corrected. I re-emerged all KDE components, don't know what did the trick :)
Thanks.
Comment 19 Davide Ferrari 2003-12-09 20:54:40 UTC
Don't want to reopen the bug but playing with KNode (closing, opening, closing and so on..) I managed to encounter again the bug. I still didn't get to reproduce it in a sure way but I'm working on it...
Comment 20 Stephan Binner 2003-12-28 12:26:58 UTC
*** Bug 71320 has been marked as a duplicate of this bug. ***
Comment 21 Gregorio Guidi 2004-01-12 17:39:23 UTC
I had troubles with the splitters, too. At restart the dockwidgets with the groups and with the articles were resized to a smaller size (not 100% reproducible).
I applied this one-liner to the source and the problem was gone. I will be grateful to anyone who explains what I've done, and maybe apply the patch
...
Index: knmainwidget.cpp
===================================================================
RCS file: /home/kde/kdepim/knode/knmainwidget.cpp,v
retrieving revision 1.20
diff -u -3 -b -r1.20 knmainwidget.cpp
--- knmainwidget.cpp    7 Jan 2004 21:33:06 -0000       1.20
+++ knmainwidget.cpp    12 Jan 2004 16:31:10 -0000
@@ -80,7 +80,7 @@
   //setup splitter behavior
   manager()->setSplitterHighResolution(true);
   manager()->setSplitterOpaqueResize(true);
-  manager()->setSplitterKeepSize(true);
+  //manager()->setSplitterKeepSize(true);

   //article view
   a_rtDock = createDockWidget("article_viewer", SmallIcon("contents"), 0,
Comment 22 Andreas Hartmann 2004-01-12 22:44:38 UTC
Subject: Re:  KNode doesn't save panes dimension between sessions

Well, problem disappeared for me by removing the geometry-option in the 
.local/... kdesktop-file. I must have forgotten, that I set this option 
sometime ago.


Please excuse - it was my fault.
Kind regards,
Andreas Hartmann

Comment 23 arutha 2004-03-09 16:50:42 UTC
I'm running KDE 3.2.0 and the internal window layout is _not_ saved between sessions. For the last 3 days I have always rearranged the positions of the left panel and the preview panel and everytime I reopen KNode the panes are in default positions.

I also don't resize the whole knode window in any way (it's maximized though).
I reapeat: this is not solved! This bug has to be reopened if it's not fixed in CVS. I'm running a completely fresh installation (no .kde/ from 3.1 used)
Comment 24 Gregorio Guidi 2004-03-09 23:40:26 UTC
Have you tried commenting out the line I pointed out in comment #21, to see if it is a proper fix?
I would like to see this bug reopened, too.
Comment 25 arutha 2004-03-10 19:39:26 UTC
No I have not. If I find the time, I could try to recompile with that tomorrow.

I also noticed yesterday that when I start knode the pane positions are not only reset, but after restarting knode again the left and the header pane are made even smaller.
Comment 26 Heinrich Wendel 2004-03-13 20:49:23 UTC
there is another bug open for this: http://bugs.kde.org/show_bug.cgi?id=67139