Version: 1.5.9 (using KDE 3.1.92 (alpha2, CVS >= 20030921), compiled sources) Compiler: gcc version 3.2.2 OS: Linux (i686) release 2.4.21 Please could you add a button to the toolbar in the message window to move the message to trash. Thanks, Ben.
Subject: Re: New: Delete Message Button on Toolbar in Message Window Are you talking about the separate reader window which you get if you doubleclick on a message in the message list?
Subject: Re: Delete Message Button on Toolbar in Message Window Yes, I did mean the separate reader window. Thanks, Ben.
Great idea, but why don't you just add a bunch of relevant buttons to it. Some suggestions: - Trash - Next Message - Previous Message Etc.
Yes. Trash Next Message Previous Message And KeyBoard Controls to them should be important additions when viewing mail standalone
this is a wonderful idea, i can't imagine why this hasn't been addressed so far. the message window buttons are very sparse and not helpful and there seems to be no way to modify them. i much prefer the popup window to the preview plane, but using it requires extra actions as i cannot do anything but print reply or forward from the message window. i'm using kmail 1.7.1 on kde 3.3.1.
I'm with Frank !
*** This bug has been confirmed by popular vote. ***
For someone converting from Outlook, this ability is sorely missed. It would seem the desired behavior, for delete or trash, would be to close the window, delete or trash the message, as appropriate, then behave as if you'd deleted the message from the list of messages. (In other words, next message, or next message in thread, or whatever your defaults are.) A really nice touch would be the ability to configure whether to end up on the message list, or to open the "next" message automatically. I prefer to do the former, but a lot of folks seem to prefer the latter.
I've posted a patch to kmail-devel.
SVN commit 583655 by winterz: Can now trash a message from the message reader window. Patch written by Christian and approved by Till. Other feature wishes mentioned in the comments should be opened as new "bugs". BUGS: 65115 PS. Christian, it is time to get your own SVN account. M +24 -0 kmreadermainwin.cpp M +2 -1 kmreadermainwin.h M +5 -1 kmreadermainwin.rc --- branches/KDE/3.5/kdepim/kmail/kmreadermainwin.cpp #583654:583655 @@ -41,6 +41,7 @@ #include "kmfolder.h" #include "kmmainwidget.h" #include "kmfoldertree.h" +#include "kmmsgdict.h" #include "kmreadermainwin.h" @@ -123,6 +124,24 @@ } //----------------------------------------------------------------------------- +void KMReaderMainWin::slotTrashMsg() +{ + // find the real msg by its sernum + KMFolder* parent; + int index; + KMMsgDict::instance()->getLocation( mMsg->getMsgSerNum(), &parent, &index ); + if (parent) { + KMMessage *msg = parent->getMsg( index ); + if (msg) { + // now delete the msg and close this window + KMDeleteMsgCommand *command = new KMDeleteMsgCommand( parent, msg ); + command->start(); + close(); + } + } +} + +//----------------------------------------------------------------------------- void KMReaderMainWin::slotPrintMsg() { KMCommand *command = new KMPrintCommand( this, mReaderWin->message(), @@ -241,6 +260,11 @@ // this, SLOT( slotSaveMsg() ), // actionCollection(), "file_save_as" ); + mTrashAction = new KAction( KGuiItem( i18n("&Move to Trash"), "edittrash", + i18n("Move message to trashcan") ), + Key_Delete, this, SLOT(slotTrashMsg()), + actionCollection(), "move_to_trash" ); + mPrintAction = KStdAction::print( this, SLOT( slotPrintMsg() ), actionCollection() ); --- branches/KDE/3.5/kdepim/kmail/kmreadermainwin.h #583654:583655 @@ -38,6 +38,7 @@ /** Copy selected messages to folder with corresponding to given menuid */ void copySelectedToFolder( int menuId ); + void slotTrashMsg(); void slotPrintMsg(); void slotReplyToMsg(); void slotReplyAllToMsg(); @@ -60,7 +61,7 @@ KURL mUrl; QMap<int,KMFolder*> mMenuToFolder; // a few actions duplicated from kmmainwidget - KAction *mPrintAction, *mReplyAction, *mReplyAllAction, *mReplyAuthorAction, + KAction *mTrashAction, *mPrintAction, *mReplyAction, *mReplyAllAction, *mReplyAuthorAction, *mReplyListAction, *mForwardInlineAction, *mForwardAttachedAction, *mForwardDigestAction, *mRedirectAction, *mViewSourceAction; --- branches/KDE/3.5/kdepim/kmail/kmreadermainwin.rc #583654:583655 @@ -1,5 +1,5 @@ <!DOCTYPE kpartgui> -<kpartgui version="5" name="kmreadermainwin" > +<kpartgui version="6" name="kmreadermainwin" > <MenuBar> <Menu noMerge="1" name="file" > <text>&File</text> @@ -7,6 +7,8 @@ <Action name="file_save_as" /> <Action name="file_print" /> <Separator/> + <Action name="move_to_trash" /> + <Separator/> <Action name="file_close" /> </Menu> <Menu noMerge="1" name="view"> @@ -52,5 +54,7 @@ <Separator/> <Action name="message_reply_menu" /> <Action name="message_forward"/> + <Separator/> + <Action name="move_to_trash" /> </ToolBar> </kpartgui>
Thank you Christian :)
*** Bug 124477 has been marked as a duplicate of this bug. ***