Bug 60588 - screensaver box blank in kcontrol
Summary: screensaver box blank in kcontrol
Status: RESOLVED NOT A BUG
Alias: None
Product: kscreensaver
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: Mandrake RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: kscreensaver bugs tracking
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-01 17:09 UTC by Robert Cunningham
Modified: 2008-05-19 17:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
kcontrol crash report (1.45 KB, text/plain)
2003-07-01 17:11 UTC, Robert Cunningham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Cunningham 2003-07-01 17:09:26 UTC
Version:           unknown (using KDE 3.1.0)
Installed from:    Mandrake Linux Cooker i586 - Cooker
Compiler:          gcc version 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk)
OS:          Linux (i686) release 2.4.21-0.13mdk

file:/home/rob/Documents/kcontrol crash report                                
the screensaver box in kcontrol is blank. the screensavers
will not activate. whenever i click the default setting kcontrol will crash.All available sceensavers should be visable but none are.
Comment 1 Maksim Orlovich 2003-07-01 17:11:00 UTC
Filed twice
Comment 2 Robert Cunningham 2003-07-01 17:11:57 UTC
Created attachment 1915 [details]
kcontrol crash report
Comment 3 Robert Cunningham 2003-07-01 17:21:55 UTC
This is a new install resolution is 800x600 , graphic card is Nvidia GetForce2DDR. 
i had mandrake 9.0 installed on the same computer and everything worked fine. 
Comment 4 Jeffrey Hoyt 2003-07-14 19:41:24 UTC
I have the same problem  My trace is a bit different, though.  Hope it helps:

(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...[New Thread 16384 
(LWP 2056)]

(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
0x40f13677 in waitpid () from /lib/i686/libpthread.so.0
#0  0x40f13677 in waitpid () from /lib/i686/libpthread.so.0
#1  0x40639e7b in KCrash::defaultCrashHandler(int) ()
   from /usr/lib/libkdecore.so.4
#2  0x4107f3b8 in __libc_sigaction () from /lib/i686/libc.so.6
#3  0x41c16986 in KScreenSaver::defaults() ()
   from /usr/lib/kde3/kcm_screensaver.so
#4  0x41960dc8 in KExtendedCDialog::slotDefault() () from /usr/lib/kcmshell.so
Comment 5 Steven P. Ulrick 2003-11-19 16:34:06 UTC
I was just wondering exactly how this was resovled, as I just downloaded and installed KDE 3.1.93 (RPM's for Fedora Core 1) and I have the exact problem stated above.  If I don't hear anything in the next day or so, I'll assume that it's okay for me to open up another bug report on this issue, as it definitely is not resolved on my system, using the current beta of KDE (11/19/2003)
Comment 6 Reinhold Kainhofer 2004-09-17 21:15:47 UTC
CVS commit by kainhofe: 

Move all todo-modifying code to the todo view, don't modify it in the list view item any longer.
Also, completely decouple the checked state of a todo and its subtodos. That connection was broken anyway... And coupling them together (e.g. a parent todo's percentage always being the average of its children, is also not ideal, since that would require that really all subtasks are implemented as sub-todos. Also, the coupling was only implemented when you checked the checkbox, not when you set the item completed via the todo editor or the rmb menu...).

CCMAIL: 60588@bugs.kde.org


  M +22 -6     kotodoview.cpp   1.177
  M +2 -0      kotodoview.h   1.77
  M +3 -46     kotodoviewitem.cpp   1.43


--- kdepim/korganizer/kotodoview.cpp  #1.176:1.177
@@ -813,22 +813,38 @@ void KOTodoView::setNewPriority(int inde
 }
 
-void KOTodoView::setNewPercentage(int index)
+void KOTodoView::setNewPercentage( KOTodoViewItem *item, int percentage )
 {
-  if ( mActiveItem && !mActiveItem->todo()->isReadOnly () ) {
-    Todo *todo = mActiveItem->todo();
+  kdDebug(5850) << "KOTodoView::setNewPercentage( " << percentage << "), item = " << item << endl;
+  if ( item && !item->todo()->isReadOnly () ) {
+    Todo *todo = item->todo();
     Todo *oldTodo = todo->clone();
 
-    if (mPercentage[index] == 100) {
+/*  Old code to make sub-items's percentage related to this one's:
+    QListViewItem *myChild = firstChild();
+    KOTodoViewItem *item;
+    while( myChild ) {
+      item = static_cast<KOTodoViewItem*>(myChild);
+      item->stateChange(state);
+      myChild = myChild->nextSibling();
+    }*/
+    if ( percentage == 100 ) {
       emit todoCompleted( todo );
     } else {
       todo->setCompleted(false);
     }
-    todo->setPercentComplete(mPercentage[index]);
-    mActiveItem->construct();
+    todo->setPercentComplete( percentage );
+    item->construct();
     emit incidenceChanged( oldTodo, todo, KOGlobals::COMPLETION_MODIFIED );
     delete oldTodo;
+  } else {
+    kdDebug(5850) << "No active item, or active item is read-only" << endl;
   }
 }
 
+void KOTodoView::setNewPercentage(int index)
+{
+  setNewPercentage( mActiveItem, mPercentage[index] );
+}
+
 void KOTodoView::setNewDate(QDate date)
 {

--- kdepim/korganizer/kotodoview.h  #1.76:1.77
@@ -160,4 +160,6 @@ class KOTodoView : public KOrg::BaseView
     void deleteTodo();
 
+    void setNewPercentage( KOTodoViewItem *item, int percentage );
+    
     void setNewPriority( int );
     void setNewPercentage( int );

--- kdepim/korganizer/kotodoviewitem.cpp  #1.42:1.43
@@ -157,5 +157,5 @@ void KOTodoViewItem::construct()
 }
 
-void KOTodoViewItem::stateChange(bool state)
+void KOTodoViewItem::stateChange( bool state )
 {
   // do not change setting on startup or if no valid todo item is given
@@ -163,48 +163,5 @@ void KOTodoViewItem::stateChange(bool st
 
   kdDebug(5850) << "State changed, modified " << state << endl;
-  QString keyd = "9";
-
-  Todo*oldTodo = mTodo->clone();
-
-  if (state)
-    mTodoView->emitCompletedSignal( mTodo );
-  else mTodo->setPercentComplete(0);
-
-  if (mTodo->hasDueDate()) {
-    QString dtStr = mTodo->dtDueDateStr();
-    QString keyt = "";
-    if (!mTodo->doesFloat()) {
-      dtStr += " " + mTodo->dtDueTimeStr();
-    }
-    setText( eDueDateColumn, dtStr );
-    keyd = mTodo->dtDue().toString(Qt::ISODate);
-  } else {
-    setText( eDueDateColumn, "" );
-  }
-  setSortKey( eDueDateColumn, keyd );
-
-  QString priorityKey = QString::number( mTodo->priority() ) + keyd;
-  if ( mTodo->isCompleted() ) setSortKey( ePriorityColumn, "1" + priorityKey );
-  else setSortKey( ePriorityColumn, "0" + priorityKey );
-
-  setText( ePercentColumn, QString::number(mTodo->percentComplete()));
-  if (mTodo->percentComplete()<100) {
-    if (mTodo->isCompleted()) setSortKey( ePercentColumn, QString::number(999) );
-    else setSortKey( ePercentColumn, QString::number(mTodo->percentComplete()) );
-  }
-  else {
-    if (mTodo->isCompleted()) setSortKey( ePercentColumn, QString::number(999) );
-    else setSortKey( ePercentColumn, QString::number(99) );
-  }
-  // @TODO: Find a way to emit startMultiModify( "..." ) somewhere so that checking all subitems will belong to the same undo item
-  QListViewItem *myChild = firstChild();
-  KOTodoViewItem *item;
-  while( myChild ) {
-    item = static_cast<KOTodoViewItem*>(myChild);
-    item->stateChange(state);
-    myChild = myChild->nextSibling();
-  }
-  mTodoView->setTodoModified( oldTodo, mTodo );
-  delete oldTodo;
+  mTodoView->setNewPercentage( this, state?100:0 );
 }