Bug 516055 - Allow external data source more options in arg config
Summary: Allow external data source more options in arg config
Status: RESOLVED FIXED
Alias: None
Product: tellico
Classification: Applications
Component: general (other bugs)
Version First Reported In: 4.1.5
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-02-15 20:12 UTC by Robby Stephenson
Modified: 2026-03-13 01:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 4.2.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robby Stephenson 2026-02-15 20:12:29 UTC
> More configurability would be splendid: for example introducing 
> custom search field names to better fit the particular use case, or a 
> possibility to enter a couple of parameters at the same time. To 
> workaround this I reused some field names like "arXiv" or "LCCN" for my 
> purposes. And to extend the search functionality by custom search 
> syntax, like searching "s:XXX key" to look for a card "key" only in the 
> set "XXX". Would be better to have more flexible search window.

https://mail.kde.org/pipermail/tellico-users/2026-February/002125.html
Comment 1 Robby Stephenson 2026-03-06 13:12:48 UTC
Git commit 4baee9651e8d73b0a3ed3bef8c2d987fc4a7ebe9 by Robby Stephenson.
Committed on 06/03/2026 at 13:11.
Pushed by rstephenson into branch 'master'.

Allow user-defined search labels for external sources.

Define up to 5 new fetch arguments and query the data source for their
labels. Switch to editable combo box for data source configuration.
FIXED-IN: 4.2.1

M  +5    -1    ChangeLog
M  +55   -9    src/fetch/execexternalfetcher.cpp
M  +2    -0    src/fetch/execexternalfetcher.h
M  +5    -0    src/fetch/fetch.h
M  +5    -0    src/fetch/fetcher.cpp
M  +4    -0    src/fetch/fetcher.h
M  +8    -3    src/fetch/fetchmanager.cpp
M  +31   -8    src/fetchdialog.cpp

https://invent.kde.org/office/tellico/-/commit/4baee9651e8d73b0a3ed3bef8c2d987fc4a7ebe9
Comment 2 Robby Stephenson 2026-03-06 13:13:31 UTC
Git commit 1722174134ccbdccb751dfce5f52789ae804c65a by Robby Stephenson.
Committed on 06/03/2026 at 13:13.
Pushed by rstephenson into branch '4.2'.

Allow user-defined search labels for external sources.

Define up to 5 new fetch arguments and query the data source for their
labels. Switch to editable combo box for data source configuration.
FIXED-IN: 4.2.1

M  +5    -1    ChangeLog
M  +55   -9    src/fetch/execexternalfetcher.cpp
M  +2    -0    src/fetch/execexternalfetcher.h
M  +5    -0    src/fetch/fetch.h
M  +5    -0    src/fetch/fetcher.cpp
M  +4    -0    src/fetch/fetcher.h
M  +8    -3    src/fetch/fetchmanager.cpp
M  +31   -8    src/fetchdialog.cpp

https://invent.kde.org/office/tellico/-/commit/1722174134ccbdccb751dfce5f52789ae804c65a
Comment 3 Tomasz Goliński 2026-03-08 11:21:54 UTC
I'm afraid it is not working correctly for me. I got rid of the usual fields and added new fields with custom labels, but they disappeared after closing "Configure tellico" dialog.
Comment 4 Robby Stephenson 2026-03-09 11:30:29 UTC
(In reply to Tomasz Goliński from comment #3)
> I'm afraid it is not working correctly for me. I got rid of the usual fields
> and added new fields with custom labels, but they disappeared after closing
> "Configure tellico" dialog.

First thought - the basic widget  behavior is that the new entry is not added to the combo box unless the user presses Enter. Is that the case? If so, I can try to do a workaround. Make sure your label is included in the dropdown before you close the dialog.
Comment 5 Tomasz Goliński 2026-03-09 12:56:45 UTC
Indeed, pressing enter seems crucial, but highly non-obvious. The dialog behaves correctly, spawns new empty fields, values gets preserved if I close a "modify" datasource dialog. However when I close the whole "configure tellico" dialog, entries disappear. To do that I just use mouse  or tab to navigate between the fields.

If I press enter though, a "open file" dialog pops up. I close it and then the values are finally stored correctly. There's no visible change indicating that the values are entered correctly.
Comment 6 Robby Stephenson 2026-03-13 01:46:29 UTC
Git commit e3f0e42937569e597e33b4307c79573c1fac3a25 by Robby Stephenson.
Committed on 13/03/2026 at 01:39.
Pushed by rstephenson into branch 'master'.

Save user label even if it wasn't submitted to the combo box

M  +23   -8    src/fetch/execexternalfetcher.cpp
M  +1    -1    src/fetch/fetch.h

https://invent.kde.org/office/tellico/-/commit/e3f0e42937569e597e33b4307c79573c1fac3a25
Comment 7 Robby Stephenson 2026-03-13 01:46:53 UTC
Git commit 2a838f5365f814ac8c6aa8487ca5d6a8cfe610e7 by Robby Stephenson.
Committed on 13/03/2026 at 01:46.
Pushed by rstephenson into branch '4.2'.

Save user label even if it wasn't submitted to the combo box

M  +23   -8    src/fetch/execexternalfetcher.cpp
M  +1    -1    src/fetch/fetch.h

https://invent.kde.org/office/tellico/-/commit/2a838f5365f814ac8c6aa8487ca5d6a8cfe610e7