Created attachment 188590 [details] look_at_buttons SUMMARY I noticed that buttons in the "File Already Exists" (RenameDialog) have different heights. Specifically, the "Write Into" and "Overwrite" buttons are shorter than the standard "Skip", "Rename", and "Cancel" buttons. Looking at the code in kio/src/widgets/renamedialog.cpp, I found that the "Write Into" button is implemented as a QToolButton, while others are standard QPushButton. Due to how the Breeze style handles these widgets, they end up with different heights when placed in the same layout. This issue seems to stem from how Breeze (or common styles) implements QToolButton vs QPushButton. It might be worth looking into a global fix in the Breeze theme. I have already create a MR about a very similar issue in Dolphin's Selection Mode: https://invent.kde.org/system/dolphin/-/merge_requests/1139 There, QToolButton also had a different size, which broke the visual alignment. STEPS TO REPRODUCE 1. Open Dolphin. 2. Try to copy a folder into a directory where a folder with the same name already exists. 3. Observe the "Already Exists as Folder" dialog buttons. OBSERVED RESULT The buttons in the bottom row have inconsistent heights. EXPECTED RESULT All buttons in the dialog should have a consistent height. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Fedora KDE 43 KDE Plasma Version: 6.5.5 KDE Frameworks Version: 6.22.0 Qt Version: 6.10.1
Created attachment 188591 [details] first dialog
If it makes sense, I would be happy to provide a fix specifically for this dialog to ensure visual consistency without touching the global Breeze theme. I am concerned that a global change might cause regressions elsewhere, while a local fix (similar to what I did for Dolphin) would be safe and immediate.
I think a global fix would be correct here. But if there's no good reason to use a mix of button types in this dialog, that's also sensible to change.