Bug 513499 - Cannot delete task dependency
Summary: Cannot delete task dependency
Status: RESOLVED FIXED
Alias: None
Product: calligraplan
Classification: Applications
Component: usability (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dag Andersen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-17 17:44 UTC by Fabian Kislat
Modified: 2025-12-17 22:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Kislat 2025-12-17 17:44:35 UTC
SUMMARY
After creating a dependency between tasks, it cannot be deleted.

STEPS TO REPRODUCE
1. Create more than two tasks.
2. Create a dependency between the tasks using the "Link" button.
3. Add a link to a task other than the one chosen by default and close the dependency editor with "OK".
4. Reopen the dependency editor using the "Link" button.
5. Select the existing relation and click the delete button (or hit Del).
6. Close the editor with "OK".
7. Reopen the link editor.

OBSERVED RESULT
The deleted link still exists.

EXPECTED RESULT
The link has been deleted and a default link is shown instead.

SOFTWARE/OS VERSIONS
All 

ADDITIONAL INFORMATION
To distinguish the incorrect behavior from the intended behavior, it's important to create a link to a task other than the one chosen by default. Alternatively, create links to more than one task. After deleting any, they all remain.

I traced down the issue to the incorrect item role being selected when updating the model item in `RelationEditorDialog::removeRelation()`. Instead of using the default in the second argument to `item->setData`, using `TASKDELETED_ROLE` fixes the problem. To resolve the issue, change line 365 of `calligraplan/src/libs/ui/RelationEditorDialog.cpp` to:
```item->setData(false, TASKDELETED_ROLE);```
and line 372 to:
```item->setData(true, TASKDELETED_ROLE);```
For reference: https://github.com/KDE/calligraplan/blob/8bf7f73431fdd8640ab92b7081c9c8496e10ebcc/src/libs/ui/RelationEditorDialog.cpp#L365
Comment 1 Albert Astals Cid 2025-12-17 22:13:58 UTC
Git commit 6962c1ee06a18b64cc32bb5742fcf42fef69025c by Albert Astals Cid, on behalf of Fabian Kislat.
Committed on 17/12/2025 at 22:13.
Pushed by aacid into branch 'master'.

Allow deleting links between tasks. Ensure changes to link type and lag are applied.
Related: bug 513495

M  +4    -4    src/libs/ui/RelationEditorDialog.cpp

https://invent.kde.org/office/calligraplan/-/commit/6962c1ee06a18b64cc32bb5742fcf42fef69025c