Bug 513230 - FavIconRequestJob fails to retrieve larger favicons
Summary: FavIconRequestJob fails to retrieve larger favicons
Status: CONFIRMED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 6.20.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: KIO Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-12 00:02 UTC by Ian Neal
Modified: 2025-12-18 15:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Neal 2025-12-12 00:02:09 UTC
SUMMARY
FavIconRequestJob should be able to deal with larger favicons

STEPS TO REPRODUCE
1. Request favicon.ico from https://www.ybs.co.uk/o/ybs-theme/images/
2. 
3. 

OBSERVED RESULT
Get KIO::FavIconRequestJob error 163 and no favicon.ico retrieved

EXPECTED RESULT
The favicon is retrieved.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
(available in the Info Center app, or by running `kinfo` in a terminal window)
Linux/KDE Plasma: Fedora Linux 42
KDE Plasma Version: 6.5.3
KDE Frameworks Version: 6.20.0
Qt Version: 6.9.3

ADDITIONAL INFORMATION
Most web browsers can make use of the larger favicons so KIO framework should do the same.
Comment 1 Nicolas Fella 2025-12-18 14:32:46 UTC
There's a somewhat arbitrary size limit in the code: https://invent.kde.org/frameworks/kio/-/blob/master/src/gui/faviconrequestjob.cpp#L189

Changing the limit would be easy, but I'm hesitant about removing it entirely
Comment 2 Ian Neal 2025-12-18 15:33:31 UTC
Biggest one I've found is 256x256 which was around 100k. Maybe take the limit to 0x20000 ?