Bug 512823 - "Focus Terminal Panel" action button mislabeled with focus changed by click
Summary: "Focus Terminal Panel" action button mislabeled with focus changed by click
Status: REPORTED
Alias: None
Product: dolphin
Classification: Applications
Component: general (other bugs)
Version First Reported In: 25.08.3
Platform: CachyOS Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-01 04:21 UTC by Jérôme L
Modified: 2025-12-01 04:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jérôme L 2025-12-01 04:21:55 UTC
SUMMARY
The "Focus Terminal Panel" and "Focus Places Panel" actions are not updated when the focus is changed by the mouse.

Also, the "Focus Places Panel" action can be mislabeled as "Defocus Terminal Panel" because of https://invent.kde.org/system/dolphin/-/blob/291edd2046544eefa8292a205fc7e78d5007fe18/src/dolphinmainwindow.cpp#L3082

STEPS TO REPRODUCE
1. Open dolphin, add the "Focus Terminal Panel" and "Focus Places Panel" actions
2. Use the actions, the text updates
3. Use the mouse to focus the main panel.

For the mislabel:
1. Hide the places panel
2. Click "Focus Places Panel"

OBSERVED RESULT
The text of the actions are not updated when changing the focus with the mouse.

For the mislabel: The action is labelled "Defocus Terminal Panel"
As a result, translations also have the same msgid twice with a different msgctxt.

EXPECTED RESULT
The labels are either always updated, or never updated. See additional information.

SOFTWARE/OS VERSIONS
Linux: 6.17.9
KDE Plasma Version: 6.5.3
KDE Frameworks Version: 6.20.0
Qt Version: 6.10.1

ADDITIONAL INFORMATION
I suggest using "Focus Terminal" and "Focus Places" all the time, because
it's less error-prone,
the icon and description already describe the toggle behavior,
consistent name in the shortcuts settings.
"Defocus" feedback is nice, but it moves the action bar, which is not pretty.

I voluntarily removed "Panel" because I think it's implicit and shorter, just like show_terminal_panel is just "Terminal".
Renaming requires more work for translators, though.