Bug 511152 - "Star" icon is slightly larger than the other buttons
Summary: "Star" icon is slightly larger than the other buttons
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (other bugs)
Version First Reported In: 6.5.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-26 12:35 UTC by Filippo
Modified: 2025-10-27 21:59 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.20
Sentry Crash Report:


Attachments
The screenshot compares the size of the "star" button to the rest of the icons. (341.86 KB, image/png)
2025-10-26 12:35 UTC, Filippo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Filippo 2025-10-26 12:35:16 UTC
Created attachment 186182 [details]
The screenshot compares the size of the "star" button to the rest of the icons.

SUMMARY
When hovering over a clipboard item, a number of options show up. The "star" option has an icon that does not match the size of other icons. While it does make starred queries easily identifiable, it also feels out of place with the other buttons.

STEPS TO REPRODUCE
1. Copy a query to clipboard.
2. Open the clipboard.
3. Hover over a query.

OBSERVED RESULT
The star icon is significantly larger than the rest.

EXPECTED RESULT
Provided that was the intended look, the star should be the same size as the other icons.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.5.0
KDE Frameworks Version: 6.19.0
Qt Version: 6.10.0
Comment 1 David Edmundson 2025-10-27 11:03:07 UTC
Code-wise it's fine. It's the same bounding box.

But I do agree it somehow looks bigger.
Comment 2 Nate Graham 2025-10-27 21:23:49 UTC
The problem appears to be that starred-symbolic and non-starred-symbolic only have 16px versions, so for the toolbuttons that display 22px icons, they get upscaled.
Comment 3 Nate Graham 2025-10-27 21:30:10 UTC
Ah, it's actually a slightly more subtle problem. It's that these icons are symlinks to *emblem* icons, which deliberately have zero outer margins. So even putting in place support for the 22px icon, it's still too big. Needs a slightly different solution.
Comment 4 Nate Graham 2025-10-27 21:59:42 UTC
Git commit 4cded973cde5869062fc2c4f62478a3395211c48 by Nate Graham.
Committed on 27/10/2025 at 21:58.
Pushed by ngraham into branch 'fix-starred-icons'.

Fix up "starred-*" icons

They suffered from a few issues, including:
- Lacking 22px versions
- Symlinking to emblem icons, which have different margins
- Lacking versions with only the base name (no -symbolic)
FIXED-IN: 6.20

M  +1    -1    icons/status/16/non-starred-symbolic.svg
A  +10   -0    icons/status/16/non-starred.svg
C  +0    -0    icons/status/16/semi-starred-rtl.svg [from: icons/status/16/semi-starred-symbolic-rtl.svg - 100% similarity]
T  +1    -13   icons/status/16/semi-starred-symbolic-rtl.svg
T  +1    -13   icons/status/16/semi-starred-symbolic.svg
C  +0    -0    icons/status/16/semi-starred.svg [from: icons/status/16/semi-starred-symbolic.svg - 100% similarity]
M  +1    -1    icons/status/16/starred-symbolic.svg
A  +10   -0    icons/status/16/starred.svg
A  +1    -0    icons/status/22/non-starred-symbolic.svg
A  +10   -0    icons/status/22/non-starred.svg
A  +1    -0    icons/status/22/starred-symbolic.svg
A  +10   -0    icons/status/22/starred.svg

https://invent.kde.org/frameworks/breeze-icons/-/commit/4cded973cde5869062fc2c4f62478a3395211c48