Bug 508664 - GCstar importer doesn't handle custom collection types
Summary: GCstar importer doesn't handle custom collection types
Status: RESOLVED FIXED
Alias: None
Product: tellico
Classification: Applications
Component: general (other bugs)
Version First Reported In: 4.1.3
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Robby Stephenson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-23 22:02 UTC by Robby Stephenson
Modified: 2025-08-24 21:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 4.1.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robby Stephenson 2025-08-23 22:02:09 UTC
Tellico should import custom GCstar collections
Comment 1 Robby Stephenson 2025-08-23 23:51:52 UTC
Requested in https://discuss.kde.org/t/collection-images-as-links/38760/
Comment 2 Robby Stephenson 2025-08-24 18:55:05 UTC
Git commit 8edb2e50438ecf88d925a53b86c78dfe149140a6 by Robby Stephenson.
Committed on 24/08/2025 at 18:54.
Pushed by rstephenson into branch 'master'.

Update GCstar importer to read external model files

Search for the gcm file in the GenericDataLocation folder, then pass the
location to the stylesheet with a parameter. The stylesheet has to
account for either internal custom fields or reading from the external
model file.

Also, update Choice fields to include the AllowMultiple flag.
FIXED-IN: 4.1.4

M  +4    -0    ChangeLog
M  +1    -1    src/collectionfactory.cpp
A  +201  -0    src/tests/data/Knives.gcm
A  +50   -0    src/tests/data/test-custom.gcs
M  +51   -0    src/tests/gcstartest.cpp
M  +1    -0    src/tests/gcstartest.h
M  +37   -4    src/translators/gcstarimporter.cpp
M  +1    -1    src/translators/gcstarimporter.h
M  +62   -29   xslt/gcstar2tellico.xsl

https://invent.kde.org/office/tellico/-/commit/8edb2e50438ecf88d925a53b86c78dfe149140a6
Comment 3 Robby Stephenson 2025-08-24 21:40:35 UTC
Git commit 0c7dc87ffd602be9acaa0c7d44174766068fbc50 by Robby Stephenson.
Committed on 24/08/2025 at 18:55.
Pushed by rstephenson into branch '4.1'.

Update GCstar importer to read external model files

Search for the gcm file in the GenericDataLocation folder, then pass the
location to the stylesheet with a parameter. The stylesheet has to
account for either internal custom fields or reading from the external
model file.

Also, update Choice fields to include the AllowMultiple flag.
FIXED-IN: 4.1.4

M  +4    -0    ChangeLog
M  +1    -1    src/collectionfactory.cpp
A  +201  -0    src/tests/data/Knives.gcm
A  +50   -0    src/tests/data/test-custom.gcs
M  +51   -0    src/tests/gcstartest.cpp
M  +1    -0    src/tests/gcstartest.h
M  +37   -4    src/translators/gcstarimporter.cpp
M  +1    -1    src/translators/gcstarimporter.h
M  +62   -29   xslt/gcstar2tellico.xsl

https://invent.kde.org/office/tellico/-/commit/0c7dc87ffd602be9acaa0c7d44174766068fbc50