Bug 508310 - Adding or removing images does not cause KCM to think there are unsaved changes
Summary: Adding or removing images does not cause KCM to think there are unsaved changes
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_wallpaper (other bugs)
Version First Reported In: 6.4.4
Platform: Fedora RPMs Linux
: HI normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-08-15 21:15 UTC by Daniel Cleaver
Modified: 2025-09-24 00:58 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.4.6
Sentry Crash Report:


Attachments
vid1: systemsettings (619.12 KB, video/webm)
2025-08-15 21:16 UTC, Daniel Cleaver
Details
vid2: desktop (1.29 MB, video/webm)
2025-08-15 21:16 UTC, Daniel Cleaver
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cleaver 2025-08-15 21:15:08 UTC
SUMMARY
In the wallpaper settings menu, newly-added images are not saved in the list. [vid1]

Compare this with the behavior of the "Desktop Folder Settings" which does remember newly-added images. [vid2]

STEPS TO REPRODUCE
1. System Settings > Wallpaper > Add
2. Select an image. It appears in the images list.
3. Do anything that causes the current "hot" state to be forgotten. For example, closing systemsettings or even navigating to a different menu.

OBSERVED RESULT
The image is no longer in the images list.

EXPECTED RESULT
The image is present.

SOFTWARE/OS VERSIONS
Operating System: Fedora Linux 42
KDE Plasma Version: 6.4.4
KDE Frameworks Version: 6.17.0
Qt Version: 6.9.1
Kernel Version: 6.15.9-201.fc42.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 12 × 12th Gen Intel® Core™ i5-12400F
Memory: 16 GiB of RAM (15.5 GiB usable)
Graphics Processor: AMD Radeon RX 6700 XT
Manufacturer: Micro-Star International Co., Ltd.
Product Name: MS-7D43
System Version: 1.0

ADDITIONAL INFORMATION
Related but non-duplicate bugs might be:
https://bugs.kde.org/show_bug.cgi?id=499808
https://bugs.kde.org/show_bug.cgi?id=489087
Comment 1 Daniel Cleaver 2025-08-15 21:16:04 UTC
Created attachment 184116 [details]
vid1: systemsettings
Comment 2 Daniel Cleaver 2025-08-15 21:16:39 UTC
Created attachment 184117 [details]
vid2: desktop
Comment 3 TraceyC 2025-08-15 23:01:29 UTC
I can reproduce this using the provided steps in git-master
Comment 4 Nate Graham 2025-08-18 20:18:48 UTC
Can also reproduce. It would appear that adding (and removing) images does not set the dirty state properly, so the KCM doesn't realize there are unsaved changes, and lets you leave without prompting you to save them.

Raising to HI since the wallpaper KCM is a frequently-used KCM and this is basic usage.
Comment 5 Bug Janitor Service 2025-09-22 19:46:59 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5833
Comment 6 Nate Graham 2025-09-22 23:21:46 UTC
Git commit 10383b2047c9db6c657ab4a51c33e22e9dad38c5 by Nate Graham.
Committed on 22/09/2025 at 21:21.
Pushed by ngraham into branch 'master'.

kcms/wallpapers: mark as dirty when the user adds or removes an image

The KCM needs to handle ConfigurationChanged signals that come from the
embedded component, which is where the signal comes from when you add or
remove images.
FIXED-IN: 6.4.6

M  +6    -0    kcms/wallpaper/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/10383b2047c9db6c657ab4a51c33e22e9dad38c5
Comment 7 Nate Graham 2025-09-22 23:38:02 UTC
Git commit 7c5e7e4201002ea3ce7a2cc254872a2eb779a577 by Nate Graham.
Committed on 22/09/2025 at 23:37.
Pushed by ngraham into branch 'Plasma/6.5'.

kcms/wallpapers: mark as dirty when the user adds or removes an image

The KCM needs to handle ConfigurationChanged signals that come from the
embedded component, which is where the signal comes from when you add or
remove images.
FIXED-IN: 6.4.6


(cherry picked from commit 10383b2047c9db6c657ab4a51c33e22e9dad38c5)

Co-authored-by: Nate Graham <nate@kde.org>

M  +6    -0    kcms/wallpaper/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/7c5e7e4201002ea3ce7a2cc254872a2eb779a577
Comment 8 Nate Graham 2025-09-22 23:38:29 UTC
Git commit f288adb9a2b27f738f1fc5dd48035f3712d34058 by Nate Graham.
Committed on 22/09/2025 at 23:38.
Pushed by ngraham into branch 'Plasma/6.4'.

kcms/wallpapers: mark as dirty when the user adds or removes an image

The KCM needs to handle ConfigurationChanged signals that come from the
embedded component, which is where the signal comes from when you add or
remove images.
FIXED-IN: 6.4.6


(cherry picked from commit 10383b2047c9db6c657ab4a51c33e22e9dad38c5)

Co-authored-by: Nate Graham <nate@kde.org>

M  +6    -0    kcms/wallpaper/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/f288adb9a2b27f738f1fc5dd48035f3712d34058
Comment 9 Marco Martin 2025-09-23 10:12:33 UTC
so, this is pretty much by design.
from the code, it saves additions and removals only when sometimes is applied, which might be worth reconsidering if is the most intuitive way.

What should at least happen for sure is at least the apply button being enabled
Comment 10 Nate Graham 2025-09-23 13:38:45 UTC
(In reply to Marco Martin from comment #9)
> What should at least happen for sure is at least the apply button being
> enabled
Yeah, that's what the bug report was about, and what was fixed with the above commit.
Comment 11 Daniel Cleaver 2025-09-24 00:58:58 UTC
Thank you Nate!