Bug 505902 - TerminalRows is one less than requested
Summary: TerminalRows is one less than requested
Status: REPORTED
Alias: None
Product: konsole
Classification: Applications
Component: general (other bugs)
Version First Reported In: 25.04.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-06-21 08:38 UTC by witekfl
Modified: 2025-06-22 12:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Do not change vertical margins (866 bytes, patch)
2025-06-22 12:59 UTC, witekfl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description witekfl 2025-06-21 08:38:24 UTC
SUMMARY
TerminalRows is one less than requested. For example for 25 is 24.

STEPS TO REPRODUCE
1. konsole -p TerminalRows=25 -p TerminalColumns=80
2. tput lines
3. 

OBSERVED RESULT
tput lines displays 24

EXPECTED RESULT
ought to be 25
Comment 1 witekfl 2025-06-22 12:59:50 UTC
Created attachment 182513 [details]
Do not change vertical margins

The bug is in TerminalDisplay::calcGeometry()
I don't know what is better. Instead of margin and -margin, 0 as in patch. or -margin replace by margin.