Bug 505544 - I can't navigate into the Remove button with the keyboard
Summary: I can't navigate into the Remove button with the keyboard
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: 6.3.91
Platform: Arch Linux Linux
: NOR major
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: accessibility, regression, usability
Depends on:
Blocks:
 
Reported: 2025-06-12 19:17 UTC by Fernando M. Muniz
Modified: 2025-06-23 18:39 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.4.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando M. Muniz 2025-06-12 19:17:19 UTC
An app killed my mouse, so I tried to tab into the Remove button in Discover... The Tab button skips that very important button.
Comment 1 Nate Graham 2025-06-13 14:58:19 UTC
Can confirm. Looks like this was caused by https://invent.kde.org/plasma/discover/-/commit/a5edba99485bb1ba9dea820149fd4c858721de5b.
Comment 2 Nate Graham 2025-06-18 18:40:30 UTC
It looks like in general setting the displayComponent of a Kirigami.Action in a Kirigami.ActionToolbar passes focus correctly. However in this case, the complexity of the InstallApplicationButton component that we're using defeats it.
Comment 3 Bug Janitor Service 2025-06-19 15:08:26 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/1122
Comment 4 cwo 2025-06-23 07:07:47 UTC
Git commit 903b3745017cf3a8bc6674702117770f1f58f072 by Christoph Wolk.
Committed on 23/06/2025 at 05:56.
Pushed by cwo into branch 'master'.

discover: include Remove button in tab chain

The Remove button was excluded from the tab chain many years ago in
07aaf62e6ac932b4fed757208db36bd882c45e4e. This makes it impossible to
get to the button using tab navigation, which wasn't a problem when the
button was used as an extra on ListView cards that users could access
through the application's full page. But now that we use it also on that
page, we need to have it included or the button isn't accessible either.

Instead, we include the button in the tab chain when it's used on the
app's page. We still leave it out for ListViews, as having potentially
hundreds of delegates included is very cumbersome (and doesn't even work
well), though we may want to adjust this in the future to include the
button if and only if it is on the currently selected delegate.
FIXED-IN: 6.4.1

M  +2    -1    discover/qml/ApplicationPage.qml
M  +2    -1    discover/qml/InstallApplicationButton.qml

https://invent.kde.org/plasma/discover/-/commit/903b3745017cf3a8bc6674702117770f1f58f072
Comment 5 cwo 2025-06-23 18:39:27 UTC
Git commit ee9ed3e22310c8fd8c267349d5091432f8392d4b by Christoph Wolk.
Committed on 23/06/2025 at 07:09.
Pushed by cwo into branch 'Plasma/6.4'.

discover: include Remove button in tab chain

The Remove button was excluded from the tab chain many years ago in
07aaf62e6ac932b4fed757208db36bd882c45e4e. This makes it impossible to
get to the button using tab navigation, which wasn't a problem when the
button was used as an extra on ListView cards that users could access
through the application's full page. But now that we use it also on that
page, we need to have it included or the button isn't accessible either.

Instead, we include the button in the tab chain when it's used on the
app's page. We still leave it out for ListViews, as having potentially
hundreds of delegates included is very cumbersome (and doesn't even work
well), though we may want to adjust this in the future to include the
button if and only if it is on the currently selected delegate.
FIXED-IN: 6.4.1


(cherry picked from commit 903b3745017cf3a8bc6674702117770f1f58f072)

Co-authored-by: Christoph Wolk <cwo.kde@posteo.net>

M  +2    -1    discover/qml/ApplicationPage.qml
M  +2    -1    discover/qml/InstallApplicationButton.qml

https://invent.kde.org/plasma/discover/-/commit/ee9ed3e22310c8fd8c267349d5091432f8392d4b