Weirdly I can't delete a LUKS partition unless it's locked.
That's intentional. Same is with mounted partitions. You need to lock it (or unmount mounted partitions). Otherwise you'll have various bad effects on your system.
(In reply to Andrius Štikonas from comment #1) > That's intentional. Same is with mounted partitions. You need to lock it (or > unmount mounted partitions). > > Otherwise you'll have various bad effects on your system. Got it, thanks. Could this be indicated to the user somehow, e.g. by making the "delete" button lock and then delete, or in a tooltip?
(In reply to closed.limelike.curves from comment #2) > (In reply to Andrius Štikonas from comment #1) > > That's intentional. Same is with mounted partitions. You need to lock it (or > > unmount mounted partitions). > > > > Otherwise you'll have various bad effects on your system. > > Got it, thanks. Could this be indicated to the user somehow, e.g. by making > the "delete" button lock and then delete, or in a tooltip? I think we can extend tooltip there but it at it can't be specific to needing locking (at least not easily). But we can add some more general tooltip. Any suggestion on text (hopefully not too long as it is a tooltip)? "Delete partition (must be not in use)" ? Or something a bit more detailed?
I'd suggest "Cannot delete partition. Please make sure it is locked and unmounted before proceeding".
Git commit adddbf5297466970f6f36dba8211aa1f97d41219 by Andrius Štikonas. Committed on 02/06/2025 at 23:17. Pushed by stikonas into branch 'master'. Add more detailed tooltip to delete partition action. M +8 -2 src/gui/mainwindow.cpp https://invent.kde.org/system/partitionmanager/-/commit/adddbf5297466970f6f36dba8211aa1f97d41219
(In reply to Andrius Štikonas from comment #5) > Git commit adddbf5297466970f6f36dba8211aa1f97d41219 by Andrius Štikonas. > Committed on 02/06/2025 at 23:17. > Pushed by stikonas into branch 'master'. > > Add more detailed tooltip to delete partition action. > > M +8 -2 src/gui/mainwindow.cpp > > https://invent.kde.org/system/partitionmanager/-/commit/ > adddbf5297466970f6f36dba8211aa1f97d41219 Thank you! (One minor thing -- shouldn't it say "unmounted and locked" instead of "unmounted or locked"? In my case the drive was already unmounted, but it wasn't locked, which is what confused me.)
being mounted or locked is kind of mutually exclusive, so "and" and "or" should be equivalent. You can't mount luks formatted file system directly, only inner file system inside luks can be mounted.