SUMMARY Since, I think, the new "Switch dynamic wallpapers" feature was merged, if I enter the Wallpaper KCM, it immediately shows it as having unsaved changes. STEPS TO REPRODUCE 1. Open System Settings for first time since the "Switch dynamic wallpapers" feature was merged 2. Navigate to Wallpaper OBSERVED RESULT An asterisk is in the titlebar. The Apply button is not greyed-out. If you click on another KCM, you are asked if you want to Discard or Apply unsaved changes. EXPECTED RESULT None of the above to happen. ADDITIONAL INFORMATION Presumably this is because a new setting has been introduced. Maybe there's an elegant way to handle this? I don't remember this sort of thing (a KCM showing it has unsaved changes) with previous Plasma upgrades, even when new settings are introduced. Thanks!
Can reproduce.
Doesn't happen on my machine.
Can you share your ~/.config/plasma-org.kde.plasma.desktop-appletsrc?
Created attachment 181862 [details] My ~/.config/plasma-org.kde.plasma.desktop-appletsrc By the way, I assume that if I click Apply, that will fix this, but I deliberately haven't done that so I can replicate this issue. And anyway, it would still be a papercut.
I applied your settings and I still can't reproduce the issue.
So this is weird, but with today's git master, I can't reproduce the issue anymore. I could yesterday with the same wallpaper settings (I haven't changed them), so either this is intermittent, or else it's fixed now. Let's call it fixed until it happens again, at which point we can investigate further.
I've just updated git master and it's still happening for me, consistently :( If I rename ~/.config/plasma-org.kde.plasma.desktop-appletsrc it doesn't happen. If I rename it back, it happens again. I notice that when I rename ~/.config/plasma-org.kde.plasma.desktop-appletsrc and logout/login again, that my wallpaper has changed. It was Nuvole and changes to Coast.
Narrowing it down, if I delete: [Containments][26][Wallpaper][org.kde.image][General] Image=/usr/share/wallpapers/Next/ PreviewImage=/usr/share/wallpapers/Next/ SlidePaths=/usr/share/wallpapers/ from my ~/.config/plasma-org.kde.plasma.desktop-appletsrc and logout/login, the issue doesn't occur. So, something to do with that?
Even more specifically, removing the line: PreviewImage=/usr/share/wallpapers/Next/ fixes the issue. Putting that line back in, it re-occurs.
Something to do with https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5344 maybe? (Rather than the "Switch dynamic wallpapers" feature).
Can reproduce with these steps. I think it's two issues - PreviewImage should not be saved in the first place (it's a bit of internal trickery we use in the desktop dialog to immediately show the wallpaper you're highlighting in the dialog), but if it is, kcm_wallpaper should not consider it changed. I'll work on a solution to both.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5539
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5541
Thanks @cwo, your MRs fix the issue I was seeing :). Hopefully they can make their way into 6.4 before release as I notice the original issue is currently present in the beta and is worse than I thought: unlike what I thought in comment 4, pressing Apply in the KCM *didn't* fix the issue, so it wouldn't have been just been a one-off papercut for users. Apologies to Vlad for incorrectly assuming this was related to the "Switch dynamic wallpapers" feature - it was the obvious visual change in the KCM when I originally saw the issue in master, but I shouldn't have made an assumption that it was to do with that.
Git commit 55cd5f0adb2a2e6f257ec2f4820b75ca40c7c3d9 by Christoph Wolk. Committed on 30/05/2025 at 13:18. Pushed by cwo into branch 'master'. kcms/wallpaper: don't load PreviewImage PreviewImage is a temporary internal key that shouldn't be stored, but was (and will still be present in existing configs, as the Containment dialog wrote it to disk). kcm_wallpaper does not write it, but if it is present in the file, it may mark the kcm as needing save to remove it. Instead, don't consider the key at all. M +1 -0 kcms/wallpaper/wallpapermodule.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/55cd5f0adb2a2e6f257ec2f4820b75ca40c7c3d9
Git commit d4ca36ad788e0ca43f8f9fce521f1e6d91fd531d by Christoph Wolk. Committed on 30/05/2025 at 15:38. Pushed by cwo into branch 'master'. wallpapers/image: clear Preview key before saving Image sets a preview key, which overrides the current main wallpaper, intended for use in the Desktop containment config dialog to immediately preview the currently selected wallpaper. This is written to the config so in effect the preview is mostly used instead of the real image setting, which is pointless. Instead, we reset it to the default (string "null") right when saving; this way the key does not end up in the file. M +1 -0 wallpapers/image/imagepackage/contents/ui/config.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/d4ca36ad788e0ca43f8f9fce521f1e6d91fd531d
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5547
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5549
Git commit a2ac73f47c194293b9f9be033fce0a1e3ce72b02 by Christoph Wolk. Committed on 03/06/2025 at 22:57. Pushed by cwo into branch 'Plasma/6.4'. kcms/wallpaper: don't load PreviewImage PreviewImage is a temporary internal key that shouldn't be stored, but was (and will still be present in existing configs, as the Containment dialog wrote it to disk). kcm_wallpaper does not write it, but if it is present in the file, it may mark the kcm as needing save to remove it. Instead, don't consider the key at all. (cherry picked from commit 55cd5f0adb2a2e6f257ec2f4820b75ca40c7c3d9) Co-authored-by: Christoph Wolk <cwo.kde@posteo.net> M +1 -0 kcms/wallpaper/wallpapermodule.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/a2ac73f47c194293b9f9be033fce0a1e3ce72b02
Git commit 0630121d79b9c7871fa47282cf37d4822324a6a8 by Christoph Wolk. Committed on 04/06/2025 at 06:14. Pushed by davidedmundson into branch 'Plasma/6.4'. wallpapers/image: clear Preview key before saving Image sets a preview key, which overrides the current main wallpaper, intended for use in the Desktop containment config dialog to immediately preview the currently selected wallpaper. This is written to the config so in effect the preview is mostly used instead of the real image setting, which is pointless. Instead, we reset it to the default (string "null") right when saving; this way the key does not end up in the file. (cherry picked from commit d4ca36ad788e0ca43f8f9fce521f1e6d91fd531d) Co-authored-by: Christoph Wolk <cwo.kde@posteo.net> M +1 -0 wallpapers/image/imagepackage/contents/ui/config.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/0630121d79b9c7871fa47282cf37d4822324a6a8