Bug 504171 - URL bar has a double border when not in toolbar
Summary: URL bar has a double border when not in toolbar
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: bars: location (other bugs)
Version First Reported In: 25.04.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
: 504055 (view as bug list)
Depends on:
Blocks:
 
Reported: 2025-05-13 18:53 UTC by Christian (Fuchs)
Modified: 2025-05-17 14:36 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 25.08.0
Sentry Crash Report:


Attachments
Screenshot of the issue (8.75 KB, image/png)
2025-05-13 18:53 UTC, Christian (Fuchs)
Details
Fixed in git master (9.33 KB, image/png)
2025-05-14 17:23 UTC, Akseli Lahtinen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2025-05-13 18:53:11 UTC
Created attachment 181252 [details]
Screenshot of the issue

SUMMARY
In dolphin the new URL bar has a double border when it is in the file view instead of the toolbar.
This makes it look very much out of place compared to the old old URL bar

STEPS TO REPRODUCE
1.  Open Dolphin
2.  Configure the URL bar to not be in the toolbar
3.  Look at it

OBSERVED RESULT
Double border

EXPECTED RESULT
No double border (as two revisions ago), neatly integrated into the UI

SOFTWARE/OS VERSIONS
All irrelevant except
KDE Frameworks Version:  6.14.0

ADDITIONAL INFORMATION
See attached screenshot
Most likely also affects all other apps that use it in this way, I only saw it in dolphin so far.
Comment 1 Akseli Lahtinen 2025-05-14 17:23:59 UTC
Created attachment 181299 [details]
Fixed in git master

Its fixed in git master branch. Maybe the fix isn't backported?
Comment 2 Nate Graham 2025-05-14 17:48:22 UTC
Git master of Dolphin, right? Which commit? Maybe it needs to be backported, if it's capable of using the new API for this conditionally.
Comment 3 Akseli Lahtinen 2025-05-14 19:32:55 UTC
(In reply to Nate Graham from comment #2)
> Git master of Dolphin, right? Which commit? Maybe it needs to be backported,
> if it's capable of using the new API for this conditionally.

Here is the commit https://invent.kde.org/system/dolphin/-/commit/9d60570ca784000cb5ef78b13861eee58117595d
Comment 4 Nate Graham 2025-05-14 19:35:59 UTC
Cool, thanks. Since it has a version check in it, it could be backported to the release/25.04 branch, and then it would show up in Dolphin 25.04.2.

I'll leave the decision and/or actions for that up to you. :)
Comment 5 Felix Ernst 2025-05-15 13:56:06 UTC
IMHO we should not backport this. I am generally a bit weary of skipping testing phases and in this case it's only a visual bug and we cannot be 100% sure the bug fix will not regress anything major e.g. in combination with theming because we would skip the beta testing phase. The next regular release is in 3 month. I think users will manage until then.
Comment 6 Christian (Fuchs) 2025-05-15 14:45:47 UTC
(In reply to Felix Ernst from comment #5)
> IMHO we should not backport this. I am generally a bit weary of skipping
> testing phases and in this case it's only a visual bug and we cannot be 100%
> sure the bug fix will not regress anything major e.g. in combination with
> theming because we would skip the beta testing phase. The next regular
> release is in 3 month. I think users will manage until then.

Yeah, no worries from my end, I managed to survive the old look for two months, I'll manage to survive this one for ~3 months for sure :)
Comment 7 Felix Ernst 2025-05-17 14:36:42 UTC
*** Bug 504055 has been marked as a duplicate of this bug. ***