Bug 503724 - "Reviews and Comments" is styled as a web URL link, but navigates pages within the dialog
Summary: "Reviews and Comments" is styled as a web URL link, but navigates pages withi...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 6.13.0
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2025-05-03 20:57 UTC by John Veness
Modified: 2025-05-31 10:01 UTC (History)
5 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/knewstuff/-/commit/e833d3140aeaa40b19fd0043c93ef5a51959c5ed
Version Fixed In: 6.15
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description John Veness 2025-05-03 20:57:51 UTC 
SUMMARY
When viewing an item in a Get New Stuff dialog, the entry "Reviews and Comments" text is in blue and underlined and changes the mouse pointer to a pointing finger on hover, despite the fact that it switches to another view in the dialog, not opening a web link. The KDE Human Interface Guidelines advise against this.

STEPS TO REPRODUCE
1. Open System Settings
2. Click on Global Theme
3. Click "Get New..."
4. Click on an item
5. Look at the "XXX Reviews and Comments" text

OBSERVED RESULT
Text is in blue and underlined and changes the mouse pointer to a pointing finger on hover.

EXPECTED RESULT
Text is in a button.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20250501
KDE Plasma Version: 6.3.4
KDE Frameworks Version: 6.13.0
Qt Version: 6.9.0
Kernel Version: 6.14.4-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
https://develop.kde.org/hig/getting_input/
Comment 1 John Kizer 2025-05-08 19:19:46 UTC 
Hi - I can see that as well, thanks!
Comment 2 Bug Janitor Service 2025-05-14 21:50:45 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/363
Comment 3 Bug Janitor Service 2025-05-28 16:52:10 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/366
Comment 4 Kristen McWilliam 2025-05-29 13:06:22 UTC 
Git commit e833d3140aeaa40b19fd0043c93ef5a51959c5ed by Kristen McWilliam, on behalf of John Veness.
Committed on 29/05/2025 at 13:06.
Pushed by merritt into branch 'master'.

Change "Comments and Reviews" link into a button

Right now this is a link but doesn't open a URL, violating the HIG
guideline against this. Instead, make it a conventional button.

With credit and many thanks to Nate Graham for his initial work on this (see !363 for more discussion).

| Before | After |
| ------ | ------ |
| ![before](/uploads/1b1ad8590cb31280e71699c24e79bcfb/before.png) | ![3](/uploads/def779c05653473bc7938ca301112472/3.png) |
| ![before_narrow](/uploads/ff7173f5d099e1c51339e7f7dcb2b75e/before_narrow.png) | ![3_narrow](/uploads/ef37cbabe396d840bcfef18b3e18170e/3_narrow.png) |

M  +8    -7    src/qtquick/qml/EntryDetails.qml

https://invent.kde.org/frameworks/knewstuff/-/commit/e833d3140aeaa40b19fd0043c93ef5a51959c5ed