Bug 503624 - Peek at Desktop and Minimize All Windows widgets have the same display name in edit mode
Summary: Peek at Desktop and Minimize All Windows widgets have the same display name i...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Edit Mode (other bugs)
Version First Reported In: 6.3.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-01 17:15 UTC by Antti Savolainen
Modified: 2025-05-08 13:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.4.0
Sentry Crash Report:


Attachments
Edit mode jank (120.75 KB, video/mp4)
2025-05-01 17:15 UTC, Antti Savolainen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Savolainen 2025-05-01 17:15:59 UTC
Created attachment 180858 [details]
Edit mode jank

SUMMARY
In edit mode both Peek at Desktop and Minimize All Windows have the same display name. See the attached video for an example

STEPS TO REPRODUCE
1. Attach  Peek at Desktop and Minimize All Windows to the taskbar
2. Enter Edit Mode
3. Hover over the widgets

OBSERVED RESULT
They both are named Peek at Desktop

EXPECTED RESULT
They should have their own names in this view

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.3.4
KDE Frameworks Version: 6.13.0
Qt Version: 6.9.0
Kernel Version: 6.14.4-arch1-2 (64-bit)
Graphics Platform: Wayland
Processors: 4 × Intel® Core™ i7-7600U CPU @ 2.80GHz
Memory: 23.2 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 620
Manufacturer: LENOVO
Product Name: 20HG0003SG
System Version: ThinkPad T470s
Comment 1 Nate Graham 2025-05-02 16:09:44 UTC
Can confirm. However the behavior seems… intentional? Because when Peek At Desktop mode is engages (as it is automatically while in Edit Mode), both widgets actually do the same thing. So the labels being the same is appropriate.

It makes a bit of sense too, since if you could minimize windows while peeking at the desktop, then nothing would visually change (since the hidden windows got minimized off-screen) and then when you stop peeking at the desktop, again nothing would visually change (because all of the to-be-unhidden windows were already minimized while hidden). That wouldn't be ideal.

So I think we have to call this intentional behavior!
Comment 2 Antti Savolainen 2025-05-02 16:24:25 UTC
I see. I get why that is the case, but for usability that seems to be a bad decision. If I pull both of these side-by-side on my taskbar, then enter edit mode to remove only one of them, there's no way to distinquish them from each other.
Comment 3 Nate Graham 2025-05-02 16:54:08 UTC
I can understand that, yeah.

Maybe we should block the "Minimize all" widget from working while "peek at desktop" is active. Then it could retain its label in Edit mode.

What do you think?
Comment 4 Antti Savolainen 2025-05-02 20:08:46 UTC
It's a possible solution. If possible disable it only when edit mode is active
Comment 5 Nate Graham 2025-05-07 21:34:53 UTC
Now that I'm digging into this, I think I was wrong and the status quo is not intentional. In fact I'm having trouble how it's possible at all.
Comment 6 Nate Graham 2025-05-07 21:40:38 UTC
Aha, it's because the Minimize All widget is really just the Peek at Desktop widget under the hood; they share code. Evidently this case isn't handled. Should be an easy fix.
Comment 7 Nate Graham 2025-05-07 21:52:11 UTC
Found the bug: https://invent.kde.org/plasma/plasma-desktop/-/blob/master/applets/showdesktop/package/contents/ui/main.qml?ref_type=heads#L55

Because these widgets allow invoking one another's functionality from their context menus, they have to be able to temporarily assume the role of the other. This is fine when the "peek at desktop" functionality is manually invoked using the context menu, but not fine when it was invoked automatically because Plasma is in Edit Mode.
Comment 8 Bug Janitor Service 2025-05-07 22:38:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2976
Comment 9 Nate Graham 2025-05-08 13:17:43 UTC
Git commit a5a7a990c7856532dfcff1bc86749d0b39c67e23 by Nate Graham.
Committed on 08/05/2025 at 13:17.
Pushed by ngraham into branch 'master'.

applets/minimizeall: don't pretend to be Peek at Desktop in edit mode

The Minimize All and Show Desktop widgets cleverly share code and are
capable of undoing one another's actions when invoking the other's
functionality from the context menu.

However this becomes less useful while in Edit mode, which invokes "Peek
at Desktop" automatically. Then both widgets claim to be "Peek at
Desktop" and it can be hard to tell which one is which as you make
changes. So let's not do that.
FIXED-IN: 6.4.0

M  +3    -1    applets/showdesktop/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/a5a7a990c7856532dfcff1bc86749d0b39c67e23