Created attachment 180799 [details] alternative icons mockup Currently, when using the "Create markers from selected timecodes" option to add markers to a certain Bin clip, something unexpected happens: Markers are added to the clip at the absolute timeline time, which in turn leads to two potential problems: 1. Markers placed outside the total length of the clip. (i.e. when the note is placed at minute 3, but the clip original length is just 1 minute). 2. Markers without a real meaning, in regard to the content of the clip. i.e. If the clip was placed starting at minute 2 of the timeline, and the note is placed at minute 3 of the timeline. When the marker is created for the clip, it will be created at minute 3 of the clip length (the timeline absolute time), while originally the note was placed to coincide with the content seen at minute 1 of the clip [shown at second 3 in the timeline]. So that clip marker will now be pointing to a time when nothing of real value happens in the clip (at least according to the original intention of the user, when creating the note). P.S. Perhaps the note timecode should be converted previously, when using the "Reassign selected timecodes to current Bin clip", so that it expresses the corresponding point using the clip timecode? If that happens, the above problems would not appear. Some other suggestions that crossed my mind: A. Preserve the note text as the name of the created markers/guides. (Currently the name is the timecode). B. The option "Create markers from selected timecodes" name perhaps could be "Create guides/markers from selected timecodes", because it will not always be creating markers. C. There's no obvious way of selecting a timecode. If you just click on one, it moves the time cursor (which is expected). The only way to select them I've found is doing a click over the description text (if any) and drag somewhere over the timecode. But perhaps a more intuitive solution could be provided for that purpose? a checkbox at the left of the timecode? dunno... D. Icons. At least to me, three out of four icons resulted somewhat confusing: D1. The "plus" icon, whereas it is commonly associated with 'adding things', within this widget (and before reading any tooltips) I expected it to be the one to click for adding the things this widget is for: a note (I failed in my attempt :) On the other hand, we already have an icon used in Timeline right click menu to symbolize adding a marker/guide. I'm sure if I had seen that icon, instead, I wouldn't be tempted to click it to add a note. :) D2. Perhaps if the "add guide" icon is used for the "Create markers from timecodes" function. The plus icon could be free to me used for the "Add Project Note" function. D3. Having two neighbor icons with a magnifying glass doesn't seem to be a great thing either. On the other hand, I know there aren't many icons to choose from, but perhaps the icon used for "OpenTimelineIO Import" could be used? (I've attached a mockup, using those icons for your consideration). As always, thanks for listening! :)
Good suggestions! Thanks, Gabriel. Also, the Search icon doesn't have a tool tip.
Git commit 7aa0b29bc15bb3bf75d179278c17340dcb5b56b3 by Jean-Baptiste Mardelle. Committed on 02/05/2025 at 11:04. Pushed by mardelle into branch 'master'. Notes widget: improve icons, automatically convert typed timecodes to links when pressing enter M +1 -1 src/mainwindow.cpp M +33 -3 src/project/dialogs/noteswidget.cpp M +13 -6 src/project/notesplugin.cpp M +1 -0 src/project/notesplugin.h https://invent.kde.org/multimedia/kdenlive/-/commit/7aa0b29bc15bb3bf75d179278c17340dcb5b56b3
Git commit 3fcf0b7a3b2e05212c34cd8e2faaf4e0974664cf by Jean-Baptiste Mardelle. Committed on 02/05/2025 at 12:31. Pushed by mardelle into branch 'master'. When creating guides/markers from project notes, use notes text. M +6 -6 src/bin/bin.cpp M +2 -2 src/bin/bin.h M +6 -5 src/core.cpp M +1 -1 src/core.h M +5 -5 src/dialogs/textbasededit.cpp M +6 -3 src/mainwindow.cpp M +37 -12 src/project/dialogs/noteswidget.cpp M +1 -1 src/project/dialogs/noteswidget.h https://invent.kde.org/multimedia/kdenlive/-/commit/3fcf0b7a3b2e05212c34cd8e2faaf4e0974664cf
Git commit dcff4f0def87547ff47472a8f130203c7c0216a9 by Jean-Baptiste Mardelle. Committed on 03/05/2025 at 04:07. Pushed by mardelle into branch 'master'. Allow reassigning a notes timecode to a timeline clip M +5 -0 src/bin/bin.cpp M +16 -0 src/core.cpp M +2 -0 src/core.h M +20 -3 src/project/dialogs/noteswidget.cpp M +2 -1 src/project/dialogs/noteswidget.h M +11 -4 src/project/notesplugin.cpp M +1 -1 src/project/notesplugin.h https://invent.kde.org/multimedia/kdenlive/-/commit/dcff4f0def87547ff47472a8f130203c7c0216a9
Thanks for the suggestions. I adjusted the icons as suggested, and ensured markers cannot be added outside clip length. Also the note is now used to create the markers/guide. Now regarding reassigning timecodes to a clip and the issue you describe, I think there are 2 valid use cases: 1. You copy/paste timecodes in the project notes - for example timecodes were received from someone who took some notes on the bin clips. This is the use case we currently cover, timecodes can be applied without modification to the bin clips. 2. You add notes in your timeline using the "add note" feature, and later want to assign the notes to a specific timeline clip. So in this case, we need to apply an offset to the timecode, accounting the clip position and in point. I have now added a new icon to the toolbar to reassing timecodes to a timeline clip (with a link icon). Please check and let me know if that works for you or if you have other suggestions. I think the only issue left is easier selecting of a timecode.
I've just seen it (I have to wait for a daily Windows version to be built to be able to see the changes). Yes, that works for me. As you say it covers both use cases very well. I've just noticed that if you add a note with the + button, type a text and then hit Enter, the V1/V2/etc part of the timeocde changes color to normal text color. Then if you use Reassign buttons, that part of the text remains fixed there. I liked how you disabled the "Create markers" button when nothing is selected, and I wonder if that's not also applicable to the "Reassign" buttons as well? As they do nothing when no timecode is selected. Side note: I believe it's new that you can now add clip markers directly to the selected clip in the timeline using numeric keyboard keys? Perhaps it was already there, but if it a new addition: Well done, I like it!! :)
Git commit b5bc58cc8f32e9dfe58415b4a4c348ebcd69e2e8 by Jean-Baptiste Mardelle. Committed on 04/05/2025 at 06:04. Pushed by mardelle into branch 'master'. Project notes: fix entering newline breaks timeline links, enable timecode actions only if relevant M +27 -5 src/project/dialogs/noteswidget.cpp M +1 -0 src/project/dialogs/noteswidget.h M +17 -7 src/project/notesplugin.cpp M +4 -0 src/project/notesplugin.h https://invent.kde.org/multimedia/kdenlive/-/commit/b5bc58cc8f32e9dfe58415b4a4c348ebcd69e2e8
Great! Working perfectly :) Thanks!
I've just noticed a couple of things when creating notes attached to bin clips: - between the clip name and the timecode digits there is an extra ':' character, instead of a space. - if later on, the clip changes its name, the note still shows the previous one.
Created attachment 180943 [details] clip_name:timecode
Created attachment 180944 [details] Changing a clip name doesn't update note name. To reproduce what's in the image: 1. Select a clip in the Project Bin. 2. Create a project note. 3. Change the clip name. 4. Create another note. End result: Two (still) functional project notes pointing to the same clip, but the one created before the name change is shown with an incorrect name.
Git commit 4da56479c40da9658aa102b2b17de3ecd1b4ab37 by Jean-Baptiste Mardelle. Committed on 06/05/2025 at 08:18. Pushed by mardelle into branch 'master'. Project notes:use space as separator for clip timecodes, update links when a clip is renamed M +4 -0 src/bin/projectitemmodel.cpp M +1 -0 src/bin/projectitemmodel.h M +17 -3 src/project/dialogs/noteswidget.cpp M +2 -0 src/project/dialogs/noteswidget.h M +29 -2 src/project/notesplugin.cpp M +1 -0 src/project/notesplugin.h https://invent.kde.org/multimedia/kdenlive/-/commit/4da56479c40da9658aa102b2b17de3ecd1b4ab37
I just tried it. it works great :) thanks!! one thing that happened while testing it, is that I inadvertently created two notes at the same timecode for the same clip. after renaming the clip, only the fist occurrence followed the name change. (I don't know the utility of having several notes at the same time for a same clip, though. It just happened by chance.)