Bug 502973 - Saving a template saves disabled built-in effects too
Summary: Saving a template saves disabled built-in effects too
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Effects & Transitions (other bugs)
Version First Reported In: git-master
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-18 16:49 UTC by Gabriel Gazzán
Modified: 2025-04-22 16:25 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 25.04.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Gazzán 2025-04-18 16:49:25 UTC
When saving an effects Template, any disabled built-in effects are saved too.
When applying the template to any other clip, the saved built-in effects get pasted and enabled(!) in the destination clip.

This happens both, for audio and video built-in effects.
Comment 1 Jean-Baptiste Mardelle 2025-04-22 12:40:12 UTC
Git commit 5cc834da3f31dd82b6404ab3a530f39166abfe17 by Jean-Baptiste Mardelle.
Committed on 22/04/2025 at 12:39.
Pushed by mardelle into branch 'release/25.04'.

Don't save disabled built-in effects when saving effect stack
FIXED-IN: 25.04.1

M  +26   -0    src/effects/effectstack/model/effectitemmodel.cpp
M  +2    -0    src/effects/effectstack/model/effectitemmodel.hpp
M  +3    -69   src/effects/effectstack/view/collapsibleeffectview.cpp
M  +0    -3    src/effects/effectstack/view/collapsibleeffectview.hpp
M  +27   -22   src/effects/effectstack/view/effectstackview.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/5cc834da3f31dd82b6404ab3a530f39166abfe17
Comment 2 Gabriel Gazzán 2025-04-22 16:25:18 UTC
Excellent!  :)
Thank you