Bug 502066 - The background colour and text of notices is inconsistent
Summary: The background colour and text of notices is inconsistent
Status: RESOLVED DOWNSTREAM
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 6.12.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-27 13:10 UTC by Riccardo Robecchi
Modified: 2025-04-03 13:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Notice shown in the icons settings (143.53 KB, image/png)
2025-03-27 13:10 UTC, Riccardo Robecchi
Details
Notice shown in the window decorations settings (193.34 KB, image/png)
2025-03-27 13:11 UTC, Riccardo Robecchi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Riccardo Robecchi 2025-03-27 13:10:42 UTC
Created attachment 179782 [details]
Notice shown in the icons settings

SUMMARY
The background colour of notices to users that content is not vetted by KDE changes depending on where you open the KNewStuff dialogue from. Opening it from the "Icons" settings, as an examples, shows a red warning; opening it from the "Window Decorations" section shows a yellow warning. The colour should be consistent (and it should be yellow, considering this is not an error but a warning). 
The text also differs, but it should probably always be the same.

STEPS TO REPRODUCE
1. Open the "Get New..." dialogue from "icons" and from "window decorations"

OBSERVED RESULT
The "icons" window shows the warning about the content not being vetted with a red background and the message "User-created content shown here hasn't been tested by KDE or your distributor for functionality or quality."
The "window decorations" dialogue has a yellow background and the message "Use caution when accessing user-created content shown here, as it may contain executable code that hasn't been tested by KDE or your distributor for safety, stability, or quality."

EXPECTED RESULT
All notices have the same text and background colour.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon
KDE Plasma Version: 6.3.3
KDE Frameworks Version: 6.12-0
Qt Version: 6.8.2

ADDITIONAL INFORMATION
Comment 1 Riccardo Robecchi 2025-03-27 13:11:05 UTC
Created attachment 179783 [details]
Notice shown in the window decorations settings
Comment 2 Nate Graham 2025-04-02 15:24:39 UTC
The background colors are different on purpose: one uses the "info" background color (blue by default) while the other one uses the "warning" background color (orange by default). This is because one is an informational message, and the other is a warning message. You can see they have different icons, too.

However your icon theme and color scheme obscure these differences. So to the extent that its a problem, it's a problem with those themes.
Comment 3 Riccardo Robecchi 2025-04-03 08:41:29 UTC
No, I get that. That is not the issue, sorry for not being clearer in my previous message. And the theme does show the difference, just in different colours. The issue is: why do icons get a "warning" message (I'm not aware of any way in which icons can wreck your system) whereas KWin decorations get an "information" message? KWin scripts get the same "info" message, but they could pose security problems and/or functionality issues. In other words: what is the rationale here for deciding what gets "warning" messages and what gets "info" messages? It is not clear at all and it seems to be inconsistent.
Comment 4 Nate Graham 2025-04-03 13:49:38 UTC
It's the opposite: Icons have the information message, while KWin decorations have the warning message. Your theming makes this unclear because the colors are quite weird; apparently it uses yellow as the warning color. the warning icon is also less clear than it is with the breeze icon theme. So these are theming issues.

The thing that makes window decorations more dangerous is that they include QML code, which is code. Icon themes don't.