Histogram cuts off last sample when using automatic bin limits STEPS TO REPRODUCE 1. Create histogram 2. turn on automatic binning 3. turn off automatic binning, increase the upper limit 4. an extra sample is displayed Operating System: TUXEDO OS KDE Plasma Version: 6.3.2 KDE Frameworks Version: 6.11.0 Qt Version: 6.8.2 Kernel Version: 6.11.0-109019-tuxedo (64-bit) Graphics Platform: Wayland Processors: 8 × AMD Ryzen 7 PRO 3700U w/ Radeon Vega Mobile Gfx Memory: 13.5 GiB of RAM Graphics Processor: AMD Radeon Vega 10 Graphics Manufacturer: LENOVO Product Name: 20NKS52L02 System Version: ThinkPad T495
(In reply to realkpavel from comment #0) > Histogram cuts off last sample when using automatic bin limits > > > STEPS TO REPRODUCE > 1. Create histogram > 2. turn on automatic binning > 3. turn off automatic binning, increase the upper limit > 4. an extra sample is displayed Can you please attach the project file or the data that you used for this histogram?
Created attachment 179661 [details] File where the histogram problem occurs Hello, attaching the file where I noticed this. Hope this helps. If I can help any other way, please let me know.
(In reply to Alexander Semke from comment #1) > (In reply to realkpavel from comment #0) > > Histogram cuts off last sample when using automatic bin limits > > > > > > STEPS TO REPRODUCE > > 1. Create histogram > > 2. turn on automatic binning > > 3. turn off automatic binning, increase the upper limit > > 4. an extra sample is displayed > > Can you please attach the project file or the data that you used for this > histogram? attached above
(In reply to realkpavel from comment #2) > Created attachment 179661 [details] > File where the histogram problem occurs > > Hello, > attaching the file where I noticed this. Hope this helps. If I can help any > other way, please let me know. Thank you! Which data did you use to reproduce this problem? I'm looking now at Rsheet from the LongStructures/Resistance spreadsheet the maximum is at 30.6849 here. To what value did you increase the maximum to see this problem?
(In reply to Alexander Semke from comment #4) > (In reply to realkpavel from comment #2) > > Created attachment 179661 [details] > > File where the histogram problem occurs > > > > Hello, > > attaching the file where I noticed this. Hope this helps. If I can help any > > other way, please let me know. > > Thank you! > > Which data did you use to reproduce this problem? I'm looking now at Rsheet > from the LongStructures/Resistance spreadsheet the maximum is at 30.6849 > here. To what value did you increase the maximum to see this problem? All three histograms show this. In the one labeled "Resistance", the transition is at the high end (28.972 -> 28.973), In Rsheet it is 30.6849 -> 30.6850, in Rcontact it is 1.08622 -> 1.08623. In addition, changing the bin limits of Rcontact LongStructures/Worksheet breaks the binning change behavior of Rcontact (if you change the limits of Rsheet, then change the limits of Rcontact, the graph of Rcontact sometimes disappears)
(In reply to Alexander Semke from comment #4) > (In reply to realkpavel from comment #2) > > Created attachment 179661 [details] > > File where the histogram problem occurs > > > > Hello, > > attaching the file where I noticed this. Hope this helps. If I can help any > > other way, please let me know. > > Thank you! > > Which data did you use to reproduce this problem? I'm looking now at Rsheet > from the LongStructures/Resistance spreadsheet the maximum is at 30.6849 > here. To what value did you increase the maximum to see this problem? All histograms are supposed to have 8 samples.
(In reply to realkpavel from comment #5) > (In reply to Alexander Semke from comment #4) > > (In reply to realkpavel from comment #2) > > > Created attachment 179661 [details] > > > File where the histogram problem occurs > > > > > > Hello, > > > attaching the file where I noticed this. Hope this helps. If I can help any > > > other way, please let me know. > > > > Thank you! > > > > Which data did you use to reproduce this problem? I'm looking now at Rsheet > > from the LongStructures/Resistance spreadsheet the maximum is at 30.6849 > > here. To what value did you increase the maximum to see this problem? > > All three histograms show this. In the one labeled "Resistance", the > transition is at the high end (28.972 -> 28.973), In Rsheet it is 30.6849 -> > 30.6850, in Rcontact it is 1.08622 -> 1.08623. In addition, changing the > bin limits of Rcontact LongStructures/Worksheet breaks the binning change > behavior of Rcontact (if you change the limits of Rsheet, then change the > limits of Rcontact, the graph of Rcontact sometimes disappears) ok, I see it now. The behavior is correct since the convention used in GSL and also in LabPlot is to define the last bin with strict < and not with <=. From GSL's documentation in https://www.gnu.org/software/gsl/doc/html/histogram.html: "Thus any samples which fall on the upper end of the histogram are excluded. If you want to include this value for the last bin you will need to add an extra bin to your histogram." We'll add more tooltip texts in LabPlot in this area to explain this behavior and to also properly document it in the documentation on https://docs.labplot.org/ Can you please check and confirm this behavior on your side, too?
(In reply to Alexander Semke from comment #7) > (In reply to realkpavel from comment #5) > > (In reply to Alexander Semke from comment #4) > > > (In reply to realkpavel from comment #2) > > > > Created attachment 179661 [details] > > > > File where the histogram problem occurs > > > > > > > > Hello, > > > > attaching the file where I noticed this. Hope this helps. If I can help any > > > > other way, please let me know. > > > > > > Thank you! > > > > > > Which data did you use to reproduce this problem? I'm looking now at Rsheet > > > from the LongStructures/Resistance spreadsheet the maximum is at 30.6849 > > > here. To what value did you increase the maximum to see this problem? > > > > All three histograms show this. In the one labeled "Resistance", the > > transition is at the high end (28.972 -> 28.973), In Rsheet it is 30.6849 -> > > 30.6850, in Rcontact it is 1.08622 -> 1.08623. In addition, changing the > > bin limits of Rcontact LongStructures/Worksheet breaks the binning change > > behavior of Rcontact (if you change the limits of Rsheet, then change the > > limits of Rcontact, the graph of Rcontact sometimes disappears) > > ok, I see it now. The behavior is correct since the convention used in GSL > and also in LabPlot is to define the last bin with strict < and not with <=. > > From GSL's documentation in > https://www.gnu.org/software/gsl/doc/html/histogram.html: > > "Thus any samples which fall on the upper end of the histogram are excluded. > If you want to include this value for the last bin you will need to add an > extra bin to your histogram." > > We'll add more tooltip texts in LabPlot in this area to explain this > behavior and to also properly document it in the documentation on > https://docs.labplot.org/ > > Can you please check and confirm this behavior on your side, too? Yes, that is the behavior I am seeing. A tooltip would certainly help. I understand the convention, it makes the bin widths the same mathematically, but I would disaggre with it if I was designing the system (since the default behavior guarantees one sample will be hidden, which will skew the data a lot in case of low sample numbers like here). But that is of course not my choice to make. Thank you for the work you're putting into this.
(In reply to realkpavel from comment #8) > (In reply to Alexander Semke from comment #7) > > (In reply to realkpavel from comment #5) > > > (In reply to Alexander Semke from comment #4) > > > > (In reply to realkpavel from comment #2) > > > > > Created attachment 179661 [details] > > > > > File where the histogram problem occurs > > > > > > > > > > Hello, > > > > > attaching the file where I noticed this. Hope this helps. If I can help any > > > > > other way, please let me know. > > > > > > > > Thank you! > > > > > > > > Which data did you use to reproduce this problem? I'm looking now at Rsheet > > > > from the LongStructures/Resistance spreadsheet the maximum is at 30.6849 > > > > here. To what value did you increase the maximum to see this problem? > > > > > > All three histograms show this. In the one labeled "Resistance", the > > > transition is at the high end (28.972 -> 28.973), In Rsheet it is 30.6849 -> > > > 30.6850, in Rcontact it is 1.08622 -> 1.08623. In addition, changing the > > > bin limits of Rcontact LongStructures/Worksheet breaks the binning change > > > behavior of Rcontact (if you change the limits of Rsheet, then change the > > > limits of Rcontact, the graph of Rcontact sometimes disappears) > > > > ok, I see it now. The behavior is correct since the convention used in GSL > > and also in LabPlot is to define the last bin with strict < and not with <=. > > > > From GSL's documentation in > > https://www.gnu.org/software/gsl/doc/html/histogram.html: > > > > "Thus any samples which fall on the upper end of the histogram are excluded. > > If you want to include this value for the last bin you will need to add an > > extra bin to your histogram." > > > > We'll add more tooltip texts in LabPlot in this area to explain this > > behavior and to also properly document it in the documentation on > > https://docs.labplot.org/ > > > > Can you please check and confirm this behavior on your side, too? > > Yes, that is the behavior I am seeing. A tooltip would certainly help. > > I understand the convention, it makes the bin widths the same > mathematically, but I would disaggre with it if I was designing the system > (since the default behavior guarantees one sample will be hidden, which will > skew the data a lot in case of low sample numbers like here). But that is of > course not my choice to make. Thank you for the work you're putting into > this. Yes, there are reasons for this convention and it's also used in other applications. We documented this topic in https://invent.kde.org/education/labplot/-/issues/815 and also ideas for how to improve here in future, just in case you're interested. I added now more explanations in the tooltip texts in https://invent.kde.org/education/labplot/-/commit/bad05b36358dcf287e19528eaf3b7c6647766049. This will be part of the next release 2.12 that I hope we can do soon. Thank you again for the confirmation and for raising our attention to this topic again!