Created attachment 179478 [details] Patch fixing the problem. I'm currently updating the pkgsrc package for digiKam from 8.5.0 to 8.6.0, and see one new compilation error on NetBSD 10.99.12/x86_64 with gcc 12.4.0: ``` digikam-8.6.0/core/libs/video/QtAVPlayer/qavstream.cpp: In function 'int streamRotation(const AVStream*)': digikam-8.6.0/core/libs/video/QtAVPlayer/qavstream.cpp:100:43: error: 'round' is not a member of 'std' 100 | auto rotation = static_cast<int>(std::round(av_display_rotation_get(reinterpret_cast<const int32_t *>(sideData)))); | ^~~~~ ``` The attached patch (removing `std::`) fixes the problem for me. (I'm sorry if I picked the wrong Component, but I think there are too many to select from in the small selection box.)
UPSTREAM bug created : https://github.com/valbok/QtAVPlayer/issues/521
Git commit bc54b20e44520208fb892f187febc20eb17852cc by Gilles Caulier. Committed on 17/03/2025 at 02:02. Pushed by cgilles into branch 'master'. update QtAvPlayer code to github master branch M +1 -0 NEWS M +9 -0 core/libs/video/QtAVPlayer/CMakeLists.txt M +2 -2 core/libs/video/QtAVPlayer/QtAVPlayer_manifest.txt M +8 -7 core/libs/video/QtAVPlayer/qavaudiocodec.cpp M +7 -7 core/libs/video/QtAVPlayer/qavaudiocodec_p.h M +12 -14 core/libs/video/QtAVPlayer/qavcodec.cpp M +12 -7 core/libs/video/QtAVPlayer/qavcodec_p.h M +16 -11 core/libs/video/QtAVPlayer/qavdemuxer.cpp M +8 -7 core/libs/video/QtAVPlayer/qavdemuxer_p.h M +25 -8 core/libs/video/QtAVPlayer/qavframecodec.cpp M +10 -7 core/libs/video/QtAVPlayer/qavframecodec_p.h M +0 -1 core/libs/video/QtAVPlayer/qavhwdevice_vdpau.cpp A +408 -0 core/libs/video/QtAVPlayer/qavmuxer.cpp * A +71 -0 core/libs/video/QtAVPlayer/qavmuxer_p.h * M +12 -6 core/libs/video/QtAVPlayer/qavpacket.cpp M +9 -6 core/libs/video/QtAVPlayer/qavpacket_p.h M +51 -6 core/libs/video/QtAVPlayer/qavplayer.cpp M +10 -6 core/libs/video/QtAVPlayer/qavplayer.h M +12 -6 core/libs/video/QtAVPlayer/qavstreamframe.cpp M +9 -6 core/libs/video/QtAVPlayer/qavstreamframe.h M +59 -8 core/libs/video/QtAVPlayer/qavsubtitlecodec.cpp M +9 -7 core/libs/video/QtAVPlayer/qavsubtitlecodec_p.h M +8 -8 core/libs/video/QtAVPlayer/qavvideocodec.cpp M +7 -7 core/libs/video/QtAVPlayer/qavvideocodec_p.h M +30 -16 core/libs/video/QtAVPlayer/qavvideoframe.cpp A +466 -0 core/libs/video/QtAVPlayer/qavwidget_opengl.cpp * A +40 -0 core/libs/video/QtAVPlayer/qavwidget_opengl.h * The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. https://invent.kde.org/graphics/digikam/-/commit/bc54b20e44520208fb892f187febc20eb17852cc
We also have std::round() in "facepipelinedetectrecognize.cpp." Does this compile fine? Maik
Yes, you're right, std::round is used in that other file. I guess (I didn't check in detail) that it includes cmath. Here's an alternate patch for QtAVPlayer that also fixes the problem and is perhaps more acceptable: ``` --- core/libs/video/QtAVPlayer/qavstream.cpp.orig 2025-03-15 14:01:45.000000000 +0000 +++ core/libs/video/QtAVPlayer/qavstream.cpp @@ -5,6 +5,7 @@ * Free Qt Media Player based on FFmpeg. * *********************************************************/ +#include <cmath> #include "qavstream.h" #include "qavdemuxer_p.h" #include "qavcodec_p.h" ```
Created attachment 179488 [details] Alternate patch, including cmath
Perhaps it's miss an include present in face pipeline and not in QtAVPlayer?
Git commit 9d50d742d2eb2ffe8809438bd073fa7a2b822b53 by Gilles Caulier. Committed on 17/03/2025 at 09:14. Pushed by cgilles into branch 'master'. add missing include following UPSTREAM bug https://github.com/valbok/QtAVPlayer/issues/521 M +1 -1 core/libs/video/QtAVPlayer/QtAVPlayer_manifest.txt M +1 -0 core/libs/video/QtAVPlayer/qavstream.cpp https://invent.kde.org/graphics/digikam/-/commit/9d50d742d2eb2ffe8809438bd073fa7a2b822b53
Thomas, All must be fixed now in digiKam code from git/master (next 8.7.0). Please double check if this file can be closed. Best Gilles Caulier
Thank you! I can confirm that the committed patch fixes the problem.
Perfect thanks