Bug 500537 - Translated strings not reflected in UI
Summary: Translated strings not reflected in UI
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-21 18:20 UTC by Emir SARI
Modified: 2025-02-25 19:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 24.12.3
Sentry Crash Report:


Attachments
screenshot 1 (1.18 MB, image/png)
2025-02-21 18:20 UTC, Emir SARI
Details
screenshot 2 (851.83 KB, image/png)
2025-02-21 18:21 UTC, Emir SARI
Details
screenshot 3 (188.10 KB, image/png)
2025-02-21 18:21 UTC, Emir SARI
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Emir SARI 2025-02-21 18:20:20 UTC
KDE neon, latest Unstable, tr_TR locale, latest Konqueror Git.

See screenshots. The strings that are not in Turkish are all actually translated, but the UI does not show the translated string.
Comment 1 Emir SARI 2025-02-21 18:20:48 UTC
Created attachment 178695 [details]
screenshot 1
Comment 2 Emir SARI 2025-02-21 18:21:09 UTC
Created attachment 178696 [details]
screenshot 2
Comment 3 Emir SARI 2025-02-21 18:21:25 UTC
Created attachment 178697 [details]
screenshot 3
Comment 4 Luigi Toscano 2025-02-23 15:49:57 UTC
There are really 3 different issues (in order of screenshot):

1) since https://invent.kde.org/network/konqueror/-/commit/8ef4a3adab0e7b04d1e9a7d9e615cff07de6f70d the content of khtmlsettingsplugin.pot is overwritten with new content that should go to temporarysavedir instead
2) the History UI files is from sidebar/ whose messages are not extracted
3) Policy and Management are not extracted because not all messages from settings/konqhtml/ are extracted (not recursive extraction). This was probably working until a few KCMs were imported into konqueror.

I will shortly fix (and backport, as this is improving untranslated strings) 1) and 3), while 2) may need a bit more of thinking.
Comment 5 Bug Janitor Service 2025-02-23 15:54:20 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/konqueror/-/merge_requests/400
Comment 6 Luigi Toscano 2025-02-23 16:01:51 UTC
Git commit 56661eb7af3088bd8636bb59d2ac38b046c7133f by Luigi Toscano.
Committed on 23/02/2025 at 15:51.
Pushed by ltoscano into branch 'master'.

temporarysavedir: fix the name of the pot file

The extraction was overwriting a different template, thus
losing several translations.

M  +1    -1    plugins/temporarysavedir/Messages.sh

https://invent.kde.org/network/konqueror/-/commit/56661eb7af3088bd8636bb59d2ac38b046c7133f
Comment 7 Luigi Toscano 2025-02-23 16:01:59 UTC
Git commit c096ffd8c33421b8ac09b515c593f4cb4d641695 by Luigi Toscano.
Committed on 23/02/2025 at 15:54.
Pushed by ltoscano into branch 'master'.

kcmkonqhtml: extract all messages from settings/konqhtml

The extraction was not recursive, probably working before
the import of some KCMs into konqueror.

M  +1    -1    settings/konqhtml/Messages.sh

https://invent.kde.org/network/konqueror/-/commit/c096ffd8c33421b8ac09b515c593f4cb4d641695
Comment 8 Luigi Toscano 2025-02-23 16:06:04 UTC
Git commit b1a0552f1db95e368dfe7ca5e24e0d67de2b08bc by Luigi Toscano.
Committed on 23/02/2025 at 16:05.
Pushed by ltoscano into branch 'release/24.12'.

kcmkonqhtml: extract all messages from settings/konqhtml

The extraction was not recursive, probably working before
the import of some KCMs into konqueror.
(cherry picked from commit c096ffd8c33421b8ac09b515c593f4cb4d641695)

M  +1    -1    settings/konqhtml/Messages.sh

https://invent.kde.org/network/konqueror/-/commit/b1a0552f1db95e368dfe7ca5e24e0d67de2b08bc
Comment 9 Luigi Toscano 2025-02-23 16:06:58 UTC
 https://invent.kde.org/network/konqueror/-/commit/56661eb7af3088bd8636bb59d2ac38b046c7133f does not need to be backported to release/24.12 because temporarysavedir was only added after the branching of release/24.12.
Comment 10 Luigi Toscano 2025-02-23 17:31:30 UTC
Regarding 2), it seems that everything string related to the sidebar/ directory is not extracted. I think I can propose a solution.
Comment 11 Bug Janitor Service 2025-02-23 17:36:52 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/konqueror/-/merge_requests/401
Comment 12 Luigi Toscano 2025-02-23 23:17:09 UTC
Git commit c81cf007d1e883b4ff88dd01e7ad6100be3ec66c by Luigi Toscano.
Committed on 23/02/2025 at 17:36.
Pushed by ltoscano into branch 'master'.

i18n: extract strings from sidebar/

For some reasons they were not extracted. One of the items
inside sidebar referenced the konqueror translation domain,
but its string were not extracted anyway.

Define a new translation domain and extract all strings
(but the ones from tree/, which is disabled, not ported even
to Qt4 and which should be removed or ported), and set
the translation domain accordingly.

It would be a bit too much to define a separate translation
file for each sidebar item, and in fact this is the case
for kcmkonqhtml, which defines a single translation domain
for several plugins/libraries.

M  +2    -0    sidebar/CMakeLists.txt
A  +5    -0    sidebar/Messages.sh
M  +0    -1    sidebar/history_module/CMakeLists.txt

https://invent.kde.org/network/konqueror/-/commit/c81cf007d1e883b4ff88dd01e7ad6100be3ec66c
Comment 13 Luigi Toscano 2025-02-24 09:52:03 UTC
Git commit f4a837a783ee3bbe098aae55cbf58b128836fad2 by Luigi Toscano.
Committed on 24/02/2025 at 09:51.
Pushed by ltoscano into branch 'release/24.12'.

i18n: extract strings from sidebar/

For some reasons they were not extracted. One of the items
inside sidebar referenced the konqueror translation domain,
but its string were not extracted anyway.

Define a new translation domain and extract all strings
(but the ones from tree/, which is disabled, not ported even
to Qt4 and which should be removed or ported), and set
the translation domain accordingly.

It would be a bit too much to define a separate translation
file for each sidebar item, and in fact this is the case
for kcmkonqhtml, which defines a single translation domain
for several plugins/libraries.
(cherry picked from commit c81cf007d1e883b4ff88dd01e7ad6100be3ec66c)

M  +2    -0    sidebar/CMakeLists.txt
A  +5    -0    sidebar/Messages.sh
M  +0    -1    sidebar/history_module/CMakeLists.txt

https://invent.kde.org/network/konqueror/-/commit/f4a837a783ee3bbe098aae55cbf58b128836fad2
Comment 14 Emir SARI 2025-02-25 07:08:10 UTC
Reopening for now, since “Credential Management” still seems to be not reflected.

Also this string is translated too, but it is also in English: https://invent.kde.org/network/konqueror/-/blob/master/kioworkers/bookmarks/kio_bookmarks_html.cpp#L85
Comment 15 Luigi Toscano 2025-02-25 11:31:39 UTC
(In reply to Emir SARI from comment #14)
> Reopening for now, since “Credential Management” still seems to be not
> reflected.

Which of the 3 screenshots is still not fixed?

> 
> Also this string is translated too, but it is also in English:
> https://invent.kde.org/network/konqueror/-/blob/master/kioworkers/bookmarks/
> kio_bookmarks_html.cpp#L85

Ok, but let's not make this a bug for each i18n issue, maybe we can solve this separately.
Comment 16 Luigi Toscano 2025-02-25 11:34:04 UTC
Git commit 8051425e88279e4e54217f0a69de9ac4cde059f5 by Luigi Toscano.
Committed on 25/02/2025 at 11:33.
Pushed by ltoscano into branch 'master'.

Fix the translation domain for the new internal kio_bookmark

TRANSLATION_DOMAIN now matches the name of the extracted message
template.

M  +1    -1    kioworkers/bookmarks/CMakeLists.txt

https://invent.kde.org/network/konqueror/-/commit/8051425e88279e4e54217f0a69de9ac4cde059f5
Comment 17 Luigi Toscano 2025-02-25 11:34:26 UTC
Git commit 1a2eca1b96677a85ca40f371b83411a1957f8b98 by Luigi Toscano.
Committed on 25/02/2025 at 11:34.
Pushed by ltoscano into branch 'release/24.12'.

Fix the translation domain for the new internal kio_bookmark

TRANSLATION_DOMAIN now matches the name of the extracted message
template.

M  +1    -1    kioworkers/bookmarks/CMakeLists.txt

https://invent.kde.org/network/konqueror/-/commit/1a2eca1b96677a85ca40f371b83411a1957f8b98
Comment 18 Emir SARI 2025-02-25 11:38:05 UTC
(In reply to Luigi Toscano from comment #15)
> (In reply to Emir SARI from comment #14)
> > Reopening for now, since “Credential Management” still seems to be not
> > reflected.
> 
> Which of the 3 screenshots is still not fixed?

First screenshot, “Credential Management” string.

Thanks for the prompt reply!
Comment 19 Luigi Toscano 2025-02-25 15:59:45 UTC
Git commit a4caafe2a238a0f5889dba6e537a45889e42248d by Luigi Toscano.
Committed on 25/02/2025 at 15:55.
Pushed by ltoscano into branch 'master'.

webenginepart: fix the translations of the kxmlgui file

Force the translation domain, and bump the version of
the file itself.

M  +1    -1    webenginepart/src/webenginepart.rc

https://invent.kde.org/network/konqueror/-/commit/a4caafe2a238a0f5889dba6e537a45889e42248d
Comment 20 Luigi Toscano 2025-02-25 16:10:33 UTC
Git commit 7638487e9b3de8796e2c9bb4d1fd9c67dc3049e9 by Luigi Toscano.
Committed on 25/02/2025 at 16:00.
Pushed by ltoscano into branch 'release/24.12'.

webenginepart: fix the translations of the kxmlgui file

Force the translation domain, and bump the version of
the file itself.
(cherry picked from commit a4caafe2a238a0f5889dba6e537a45889e42248d)

M  +1    -1    webenginepart/src/webenginepart.rc

https://invent.kde.org/network/konqueror/-/commit/7638487e9b3de8796e2c9bb4d1fd9c67dc3049e9