Bug 500330 - [plasma-nm] Disconnection but available network icon uses /Devices rather than from /places folder.
Summary: [plasma-nm] Disconnection but available network icon uses /Devices rather tha...
Status: RESOLVED DOWNSTREAM
Alias: None
Product: plasmashell
Classification: Plasma
Component: Networks widget (show other bugs)
Version: 6.3.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-18 16:29 UTC by Erwin Iosef
Modified: 2025-03-04 15:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Image showing icon of network-wired-available and network-wired respectively in two places (21.72 KB, image/png)
2025-02-19 11:03 UTC, Erwin Iosef
Details
attachment-1015441-0.html (1.76 KB, text/html)
2025-03-04 10:46 UTC, Erwin Iosef
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erwin Iosef 2025-02-18 16:29:36 UTC
SUMMARY

When showing a disconnected but present network, plasma-nm uses the icon from 32x32/devices rather than places/ where the appropriate symbolic icon for it would be kept. It's not shown in Breeze because the icon for the networks are symbolics across all folders(including devices/ and places/). But in Papirus Icons, it shows to be a problem.

STEPS TO REPRODUCE
1. Install Papirus icons from your favourite repo/git master and set as default.
2. Have plasma-nm installed and network disconnected but present(not unplugged).
3. Re-connect it and see the problem.

OBSERVED RESULT
https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/3941

EXPECTED RESULT
Since it's from a panel sidebar, I'd assume the proper icon for it must be selected from 32x32/places/ ?

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.3.1
KDE Frameworks Version: 6.11.0
Qt Version: 6.8.2
Comment 1 Erwin Iosef 2025-02-18 17:00:59 UTC
I should add that the icon seems a bit blurry in default breeze and when I changed it with Papirus's icon, that looked blurry too so it maybe a size mismatch as well? I have 16x9 monitor for reference.
Comment 2 Nate Graham 2025-02-18 17:56:25 UTC
Are you saying the problem is that we're asking for "network-wired-available" (which I guess is colorful in Papirus, but not Breeze) rather than "network-wired-available-symbolic"?
Comment 3 Erwin Iosef 2025-02-18 18:00:35 UTC
No, actually it was looking for `network-wired.svg` rather than `network-wired-available.svg`. I tested this myself by replacing the svg in Papirus with another and reapplying the icon. Also is it the right behaviour for it to look in devices/?
Comment 4 Erwin Iosef 2025-02-18 18:05:41 UTC
I don't think it's looking for available. If it did then the wire side of it should have a color right? Mine just looks like the normal network-wired.svg
Comment 5 Nate Graham 2025-02-18 18:21:59 UTC
As far as I can tell from reading the code, that's the icon it's displaying for disconnected networks. See https://invent.kde.org/plasma/plasma-nm/-/blob/master/libs/connectionicon.cpp?ref_type=heads#L422
Comment 6 Erwin Iosef 2025-02-19 11:01:50 UTC
Yes and it's the icon that appears on the panel, not the sidebar which pops up when you click on the applet to view connections. Right now the problem I'm describing is on that pop up which uses 'network-wired.svg' when you disconnect to it but still available for re-connection.
I'm adding an attachment for more clarification. For the context in relating to Papirus though I recommend visiting the github page I posted which could help more in understanding than me posting the images here.
Comment 7 Erwin Iosef 2025-02-19 11:03:41 UTC
Created attachment 178580 [details]
Image showing icon of network-wired-available and network-wired respectively in two places
Comment 8 Nate Graham 2025-02-19 22:30:43 UTC
Ok. so basically, network-wired looks symbolic in Breeze, but has an inappropriately colorful appearance with Papirus? Does Papirus have a symbolic version of that icon somewhere?
Comment 9 Erwin Iosef 2025-02-20 09:54:05 UTC
In panels folder, from  32x32 to 42x42/devices and one network-wired-symbolic.svg in status folder, yes.
I think the network-wired image should be picked at panels, rather than devices folder since the icons at the sidemenu for the applets have their roots in the panel. It's not a big deal for Breeze since they all use the same icons regardless of folders anyway.

Or the status folder if you feel as if the available networks in the sidemenu are a matter of status rather than available devices.
Comment 10 Nate Graham 2025-02-26 18:40:13 UTC
Let's step back a bit.

The app gets to determine three things:
- the name of the icon it asks for
- the name of the icon to use instead if no icon with that name is found
- the size the icon will be displayed at

Given these pieces of information, the icon loader looks in the icon theme for an approriately-named icon at that size. If it doesn't find one, there are various fallback heuristics.

As far as I can tell, we're not the problem here. We're sensibly asking for an icon of the right name at a normal size. If the icon we get back from Papirus doesn't look right, that's an issue in Papirus. This matter of different icons in different folders and categories isn't relevant; all of that is purely for developers' organization purposes. The icon loader doesn't care about it.
Comment 11 varlesh 2025-03-04 08:34:44 UTC Comment hidden (spam)
Comment 12 varlesh 2025-03-04 08:44:33 UTC Comment hidden (spam)
Comment 13 Erwin Iosef 2025-03-04 10:46:36 UTC
Created attachment 179105 [details]
attachment-1015441-0.html

Sorry to respond late, but thanks for the reply Nate, and if what you say
is true then it means that Papirus probably isn't offering the appropriate
icon size for the network and the icon loader just used the one that met
its size regardless of location. So maybe icon size is the point of failure
here. I'll see what I can do to work around it and report back in case of
anymore enquiries.

On Tue, 4 Mar 2025, 14:14 varlesh, <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=500330
>
> --- Comment #12 from varlesh <varlesh@gmail.com> ---
> If there is a goal to add a monochrome icon, then it is better to add a
> prefix
> -symbolic. You add icons according to the principle - this icon is in the
> Breeze icon theme, it's monochrome - OK!
>
> You're breaking the compatibility of third-party icon themes. Why do we
> need
> stores with icon themes? Or should we follow the Breeze style, create a
> separate branch for KDE and constantly monitor your changes in widgets,
> etc.
>
> We need to standardize the development and at least think a little about
> supporting third-party themes.
>
> By the way, Papirus is used in many distributions as the default icon
> theme.
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 14 varlesh 2025-03-04 15:13:31 UTC Comment hidden (spam)