Bug 499723 - Crash on every download attempt
Summary: Crash on every download attempt
Status: RESOLVED WAITINGFORINFO
Alias: None
Product: kasts
Classification: Applications
Component: general (other bugs)
Version First Reported In: 24.12.1
Platform: Manjaro Linux
: NOR crash
Target Milestone: ---
Assignee: bart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-09 16:03 UTC by lencho
Modified: 2025-02-11 07:54 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lencho 2025-02-09 16:03:13 UTC
Since the last update, I'm having the application crash everytime I download, just as the download is about to finish (or maybe it finished successfully but crashes right after).

Error (when launched from Konsole) says:
TagLib: Could not open file xxx.mp3
TagLib: FileRef::audioProperties() - Called without a valid file.
zsh: segmentation fault (core dumped)  kasts
Comment 1 bart 2025-02-09 16:09:12 UTC
We will need more information to debug this.
Could you share the podcast and episode that is failing?  If you don't like to share that info publicly, then you can also email it directly.
Comment 2 lencho 2025-02-09 16:23:21 UTC
Well, it is every episode of every podcast I try!
But I think I got it, it fails to parse the path of the file because it contains an accentuated letter. If I save the podcasts to /home/myuser it's fine!
Note that is broke since last update, because it used to work fine in the same path.
Comment 3 lencho 2025-02-09 16:24:46 UTC
I noticed already Kasts is a bit cautious/lazy (sorry!) and just removes accentuated letters from the file names, but now it fails with the path because it cannot do anything about it.
Comment 4 bart 2025-02-09 17:03:12 UTC
I still don't understand where the special character is.  Is it in the path that you've pointed it to to save episodes?  Is it in the name of the podcast, or in the name of the episode?  Or somewhere else?

Nothing has changed to that part of the code since many versions, so if it didn't happen before, then maybe it's in some dependency lib.
Comment 5 lencho 2025-02-09 21:54:14 UTC
Yes, in the path where to save the episode, sorry if I was not clear. If it's not in Kasts, do you know where it could come from? Thanks,
Comment 6 bart 2025-02-10 13:02:45 UTC
Could you perhaps mention which character is causing the issue?

In the meantime, I have an idea about a potential cause for the crash.  Especially given that you mentioned that it only popped up since the last version.
Comment 7 bart 2025-02-10 13:33:31 UTC
Confirmed with an accented character.
I see what's happening here: the taglib library was not getting the correct path if there were special characters involved.  The fix is fairly easy.  It should be fixed in the next release.
Comment 8 Bug Janitor Service 2025-02-10 14:07:35 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kasts/-/merge_requests/242
Comment 9 bart 2025-02-10 14:10:45 UTC
Git commit 43f0e8c90188c5e97104eb5dea7d7f7dbf49a504 by Bart De Vries.
Committed on 10/02/2025 at 14:02.
Pushed by bdevries into branch 'master'.

Fix path being passed to taglib and avoid opening non-existent files

M  +9    -7    src/enclosure.cpp
M  +7    -5    src/models/chaptermodel.cpp
M  +1    -1    src/models/chaptermodel.h

https://invent.kde.org/multimedia/kasts/-/commit/43f0e8c90188c5e97104eb5dea7d7f7dbf49a504
Comment 10 bart 2025-02-10 14:13:15 UTC
Git commit 42987516e9efdbed2f2a2dbb3800a6e6c0d312eb by Bart De Vries.
Committed on 10/02/2025 at 14:12.
Pushed by bdevries into branch 'release/24.12'.

Fix path being passed to taglib and avoid opening non-existent files

M  +9    -7    src/enclosure.cpp
M  +7    -5    src/models/chaptermodel.cpp
M  +1    -1    src/models/chaptermodel.h

https://invent.kde.org/multimedia/kasts/-/commit/42987516e9efdbed2f2a2dbb3800a6e6c0d312eb
Comment 11 lencho 2025-02-11 07:54:35 UTC
Great, thank you for your promptness, Bart!