Bug 499662 - Important buttons shouldn't be hidden in the toolbar overflow
Summary: Important buttons shouldn't be hidden in the toolbar overflow
Status: REPORTED
Alias: None
Product: Keysmith
Classification: Applications
Component: General (other bugs)
Version First Reported In: 24.12.0
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Bhushan Shah
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-07 19:57 UTC by Grósz Dániel
Modified: 2025-02-10 15:08 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Grósz Dániel 2025-02-07 19:57:16 UTC
SUMMARY
The Keysmith GUI is confusing in various ways because if the window is narrow (as on a smartphone screen in portrait mode, but also the default window size on Linux), various core functionality appears only in the ⋮ menu. (Not to be confused with the  ≡ menu, which only contains the About action!)

- On the main screen, on Android in Keysmith 25.03.70, the Scan QR Code action is in the ⋮ menu (depending on screen size and scaling). This function doesn't work for me at the moment (and is not available at all on 24.12.0 on desktop Linux), but once it does it, will be the easiest way to add accounts.
- On the Add new account screen, the Add button, and possibly also the Cancel button, are in the ⋮ menu. There is a big "Add new account" title, which one may first think is a button, but it isn't. It took me a while to realize that I had to use the Add button in the ⋮ menu to complete the procedure. When the Cancel button is also invisible, one may be inclined to use the Back (<) button in its stead to cancel the procedure, which in turn results in the Add and other toolbar actions missing completely on the main screen, with only a Forward (and a disabled Back) button instead.

These buttons should always be visible, either as normal buttons at the bottom, or at the top on a separate line if necessary. For the Add and Cancel buttons on the Add new account screen, the most natural would be at the bottom, following the platform's standard button order (on KDE, Cancel button on the right). I don't know what the point is of the recent trend of putting important buttons at the top; it seems to have little inherent benefit or drawback, but it's not where experienced desktop users would expect to find them, while on smartphones it makes them harder to reach. But at least they should be visible.

STEPS TO REPRODUCE
1. Make the window narrow. Or, on a smartphone, use big text/UI elements.
2. Click/tap Add....

OBSERVED RESULT
The top of the window looks like this:
≡<> Add new account   ⋮
(Cancel and Add in the ⋮ menu.)

Or possibly
≡<> Add new account   Cancel ⋮
(Add in the ⋮ menu.)

EXPECTED RESULT
Both Add and Cancel visible.

SOFTWARE/OS VERSIONS
Android:
Keysmith 25.03.70 installed from the F-Droid KDE Unstable repository, on crDroid 10.11, based on LineageOS 21, based on Android 14.

Desktop Linux:
Keysmith 24.12.0
Operating System: openSUSE Tumbleweed 20250108
KDE Plasma Version: 6.2.5
KDE Frameworks Version: 6.9.0
Qt Version: 6.8.1
Kernel Version: 6.12.8-2-default (64-bit)
Graphics Platform: X11
Comment 1 Grósz Dániel 2025-02-10 15:08:18 UTC
Related (to the part that if you use the Back (<) button to cancel adding an account, on desktop Linux it results in the Add and other toolbar actions missing on the main screen): Bug 499664.