SUMMARY Thumbbar - Both original and v1 of image show up in thumbbar after aspect ratio crop "OK" STEPS TO REPRODUCE 0. in Image editor preferences > Versioning, de-select "Always show original images" and "Always show intermediate snapshots" 1. go into Image editor 2. crop image using aspect ratio crop, hit "OK" OBSERVED RESULT 3. after "OK", crop happens, but thumbnail not updated in thumbbar 3a. if you hit right-arrow, both original image and v1 of image (cropped) show up in thumbbar EXPECTED RESULT 4. If you close image editor (back to thumbnail gallery), then open Image editor again, only v1 of image (cropped) shows up in thumbbar (as expected, based on Image editor preferences) SOFTWARE/OS VERSIONS macOS: Sequoia 15.1.1
The thumbnail in the thumbbar only changes after saving, not when you have applied a tool. If you save and the original image is not hidden, the original image was not original and already had a history. Maik
If hitting "OK" in aspect ratio crop is the same as "save", then is that different from applying the tool? If I hit "OK", the crop happens on the large image in the image editor, but the image hsitory is not updated to show the crop, and the thumbnail is not updated in thumbbar. If I hit right-arrow or left arrow, a thumbnail of both the original image and of the cropped image shows up in the thumbbar. If I close the image editor then re-open the image editor, then only the most-recent thumbnail is shown in the thumbbar, as expected.
When you press "ok" in the aspect ratio crop tool, only the current editing step will be applied to the image. Of course, this will *not* save it or adjust the history or the thumbnail. Maik
So pressing "OK" in the Image Editor is _NOT_ the same as "Save". That's not obvious at all. But I see that hitting "OK" enables "Save Changes"., so "OK" is not the same as "Save". At least in the Image Editor. However.......... If I hit "OK", then (for example) the left arrow (without hitting "Save"), a thumbnail of both the original image and of the cropped image shows up in the thumbbar. And the "Save Changes" option goes away. Having both the the original image and the cropped image in the thumbbar is not the expected behavior.
Why is it not clear to you that "ok" only applies the current tool to the image? You may want to use other tools. You have activated the automatically image save without asking in the digiKam settings under Editor->Versioning. The default is that a query appears asking whether you want to save. So you have activated automatic saving when you leave the editor or move to the next image. Maik
Even if I activate the automatic image save (without asking in the digiKam settings under Editor->Versioning), when I move to the next image, a thumbnail of both the original image and of the cropped image shows up in the thumbbar. This is not the expected behavior, is it? IMO, the expected behavior (after automatic image save) is for only the cropped image to be displayed in the thumbbar
I think I understand your problem. You want the original image to disappear from the thumbbar in the editor after saving. Well, actually it would only be one line of code to apply the version settings to the thumbbar. Actually, I wouldn't do it at the moment. We also don't use the grouping function in the thumbbar at the user's request. If the original image disappears when it is saved, I can't "quickly" switch between the original and the new version to compare. There is a function to load "original", but that's not really that practical. @Gilles, your point of view please. Apply version settings to the editor thumbbar? Maik
>@Gilles, your point of view please. Apply version settings to the editor thumbbar? I remember to seen this request in mailing list in the past without objection in the talk, but this have never seen done. It's clear that a similar behavior between icon-view and thumbbar-view is a good value. +1 for me. The Q is : another setting for this feature in the setup dialog ? Best Gilles
Another setting would only complicate things unnecessarily. Then we apply the versioning settings to the thumbbar as well. Maik
Git commit 085f8327b8682d3caf9a8c8a4744fd64f659e8a2 by Maik Qualmann. Committed on 15/02/2025 at 20:54. Pushed by mqualmann into branch 'master'. apply versioning settings to the editor thumb bar FIXED-IN: 8.6.0 M +1 -1 NEWS M +1 -0 core/utilities/imageeditor/main/imagewindow_config.cpp M +4 -0 core/utilities/imageeditor/main/imagewindow_setup.cpp https://invent.kde.org/graphics/digikam/-/commit/085f8327b8682d3caf9a8c8a4744fd64f659e8a2