Bug 499336 - Feature request: Include filtered events in search, at least as an option
Summary: Feature request: Include filtered events in search, at least as an option
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: search (show other bugs)
Version: 5.19.3
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-30 17:11 UTC by Rickard Westman
Modified: 2025-03-10 19:19 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rickard Westman 2025-01-30 17:11:20 UTC
SUMMARY

I've been bitten by this problem several times now, albeit rarely enough that I keep forgetting that it's an issue.  I usually don't want recurring events to clutter my agenda and month view, so I have set up a "non-recur" filter for that, intended only as a filter for the calendar views.  But it also excludes those elements from search, which is not intuitively obvious – I don't think it's mentioned anywhere in the UI, and the term "view filter" does not hint that it also works as a search filter.

STEPS TO REPRODUCE
1. Set up a filter using "Settings / Manage view filter" that would match at least one event.
2. Activate the filter and verify that the event disappears from the calendar view.
3. Search for the item, taking care to specify a date range that includes the hidden event.

OBSERVED RESULT
The hidden event is not shown in the search result.

EXPECTED RESULT
Expected the event to show up before I realized (multiple times) that the view filter was also a search filter.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 22.04.5 LTS
KDE Plasma Version: 5.24.7
KDE Frameworks Version:  5.92.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
I'm not sure having the view filter act as a search filter is good as a default.  The search dialog already has some option tick boxes, and my preferred change would be to add one for "Include events matched by view filter" and make it the default.  If the current default is kept, or this suggestion is not implemented at all, consider changing the term from "view filter" to "view/search filter" or just "filter".
Comment 1 Bug Janitor Service 2025-03-10 15:52:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/pim/korganizer/-/merge_requests/137
Comment 2 Allen Winter 2025-03-10 19:17:48 UTC
Git commit f70c524086ea7697e3ba3fb0cecfb3a738858854 by Allen Winter.
Committed on 10/03/2025 at 15:47.
Pushed by winterz into branch 'master'.

Add a search option to consider the current view filter

By default, the current view filter is ignored when searching.
The user can override that.

M  +37   -7    src/dialog/searchdialog.cpp
M  +38   -22   src/ui/searchdialog_base.ui

https://invent.kde.org/pim/korganizer/-/commit/f70c524086ea7697e3ba3fb0cecfb3a738858854
Comment 3 Allen Winter 2025-03-10 19:18:12 UTC
Git commit 2233d47a34937b5e98edac6a60bfc2d4f2990dd3 by Allen Winter.
Committed on 10/03/2025 at 19:18.
Pushed by winterz into branch 'release/25.04'.

Add a search option to consider the current view filter

By default, the current view filter is ignored when searching.
The user can override that.


(cherry picked from commit f70c524086ea7697e3ba3fb0cecfb3a738858854)

Co-authored-by: Allen Winter <winter@kde.org>

M  +37   -7    src/dialog/searchdialog.cpp
M  +38   -22   src/ui/searchdialog_base.ui

https://invent.kde.org/pim/korganizer/-/commit/2233d47a34937b5e98edac6a60bfc2d4f2990dd3