Bug 498989 - User avatar crop should probably default to no cropping
Summary: User avatar crop should probably default to no cropping
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_users (show other bugs)
Version: 6.2.5
Platform: unspecified Linux
: VLO wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-22 03:00 UTC by forestbeasts
Modified: 2025-01-25 10:16 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.0
Sentry Crash Report:


Attachments
The avatar cropper defaulting to a really tiny circle. (209.68 KB, image/png)
2025-01-22 03:00 UTC, forestbeasts
Details

Note You need to log in before you can comment on or make changes to this bug.
Description forestbeasts 2025-01-22 03:00:16 UTC
Created attachment 177582 [details]
The avatar cropper defaulting to a really tiny circle.

SUMMARY
When changing a user avatar, it applies a (really tiny) crop by default, instead of letting you set a picture without a crop.

STEPS TO REPRODUCE
1. Open Users KCM.
2. Click on the avatar to change it.
3. Select an image file.

OBSERVED RESULT
The avatar cropper defaults to a tiny circle, making it difficult to perfectly set an uncropped picture and be sure it's uncropped.

EXPECTED RESULT
The avatar cropper defaults to no cropping, so you can just hit OK if you don't want to crop the picture.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 40
KDE Plasma Version: 6.2.5
KDE Frameworks Version: 6.9.0
Qt Version: 6.7.2

ADDITIONAL INFORMATION
Gajim has a similar problem (except worse, because it's nigh impossible to get a 100% crop there even by dragging the cropper to the edges; it often sneakily only crops to 99% or so which you can tell by dragging around the cropper square) and closed a "please default to 100% crop" issue as wontfix saying otherwise people wouldn't know you can crop.

This isn't really a problem IMO, it's clearly a cropper, and KDE's being a circle with obvious drag handles makes it even more obvious.
Comment 1 David Edmundson 2025-01-22 10:24:26 UTC
>The avatar cropper defaults to a tiny circle, making it difficult to perfectly set an uncropped picture and be sure it's uncropped.

Maybe, but it's also important to make the drag handles prominent so it's clear what needs doing next. 
It's also always shown as a circle because the places where the avatar are shown crop it to a circle - not this step.
Comment 2 forestbeasts 2025-01-23 02:39:38 UTC
Makes sense! I wasn't trying to say that the circling and the drag handles were a bad thing, heh, quite the opposite - just that they make it pretty clear that it's a cropper UI.

IMO the current UI, just defaulting to no crop (100% width/height), would be perfect.

-- Frost
Comment 3 Bug Janitor Service 2025-01-23 17:34:54 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5107
Comment 4 Nate Graham 2025-01-24 16:05:52 UTC
Git commit 18795550b2236b97a646d16f2615509a5e19e285 by Nate Graham.
Committed on 24/01/2025 at 15:10.
Pushed by ngraham into branch 'master'.

kcm/users: make cropper fill largest square within image by default

Right now it's quite small and requires you to manually resize it, which
is annoying if your image was already well-positioned. Instead, fill the
image (or the largest square that fits within it) with the cropper.
FIXED-IN: 6.3.0

M  +6    -2    kcms/users/src/ui/CropSheet.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/18795550b2236b97a646d16f2615509a5e19e285
Comment 5 Nate Graham 2025-01-24 16:41:51 UTC
Git commit 9f9dea1b17b70e8202a5660723dcfff701e8d34a by Nate Graham.
Committed on 24/01/2025 at 16:07.
Pushed by ngraham into branch 'Plasma/6.3'.

kcm/users: make cropper fill largest square within image by default

Right now it's quite small and requires you to manually resize it, which
is annoying if your image was already well-positioned. Instead, fill the
image (or the largest square that fits within it) with the cropper.
FIXED-IN: 6.3.0


(cherry picked from commit 18795550b2236b97a646d16f2615509a5e19e285)

Co-authored-by: Nate Graham <nate@kde.org>

M  +6    -2    kcms/users/src/ui/CropSheet.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/9f9dea1b17b70e8202a5660723dcfff701e8d34a