Bug 498710 - Custom Effects with a colon in the name are not retained
Summary: Custom Effects with a colon in the name are not retained
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: 24.12.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-15 22:09 UTC by SMERKIN 5000
Modified: 2025-01-17 13:22 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 24.12.2
Sentry Crash Report:


Attachments
Three screenshots (108.84 KB, application/x-zip-compressed)
2025-01-15 22:09 UTC, SMERKIN 5000
Details

Note You need to log in before you can comment on or make changes to this bug.
Description SMERKIN 5000 2025-01-15 22:09:19 UTC
Created attachment 177384 [details]
Three screenshots

SUMMARY
If I create a custom effect with a colon in the name, the next time Kdenlive is loaded it no longer exists. This then effects a project that referenced that custom effect as it no longer exists.

STEPS TO REPRODUCE
1. Create a custom effect and put a colon in the name, I chose Test: and then I also applied it to a project (see screenshot 1)
2. Close Kdenlive and then open it again. Go to the Custom Effects section and this effect no longer is listed (see screenshot 2)
3. Open the project from step 1 and you'll get a warning for Clip Problems (see screenshot 3)

OBSERVED RESULT
Custom Effects with a colon in the name are not retained

EXPECTED RESULT
If a colon is a character not allowed, prevent the user from saving the effect or allow colons to be used.

SOFTWARE/OS VERSIONS
Windows: 10 Version 22H2 (x86_64)
KDE Frameworks Version: 6.9.0
Qt Version: 6.8.0
Comment 1 Jean-Baptiste Mardelle 2025-01-17 13:22:21 UTC
Git commit 63f05b6a6b6110320a72e48288c6f77be2373b6c by Jean-Baptiste Mardelle.
Committed on 17/01/2025 at 13:21.
Pushed by mardelle into branch 'release/24.12'.

Backport fix for invalid file names in custom effects
FIXED-IN: 24.12.2

M  +9    -7    src/effects/effectstack/view/collapsibleeffectview.cpp
M  +2    -1    src/effects/effectstack/view/effectstackview.cpp
M  +7    -0    src/utils/qstringutils.cpp
M  +2    -0    src/utils/qstringutils.h

https://invent.kde.org/multimedia/kdenlive/-/commit/63f05b6a6b6110320a72e48288c6f77be2373b6c