Bug 498629 - s390x: fix S[L]HHHR and S[L]HHLR insns
Summary: s390x: fix S[L]HHHR and S[L]HHLR insns
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: vex (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Florian Krohm
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-13 22:19 UTC by Florian Krohm
Modified: 2025-03-22 18:57 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Fix IR generation for S[L]HHHR and S[L]HHLR insns (2.65 KB, patch)
2025-03-03 15:06 UTC, Florian Krohm 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Krohm 2025-01-13 22:19:20 UTC 
POP: 
The third operand is subtracted from the second operand, and the difference is placed at the first-
operand location.

guest_s390_toIR.c:
static const HChar *s390_irgen_SHHHR(UChar r3 __attribute__((unused)), UChar r1, UChar r2)
static const HChar *s390_irgen_SHHLR(UChar r3 __attribute__((unused)), UChar r1, UChar r2)
Comment 1 Florian Krohm 2025-01-13 22:34:22 UTC 
and likewise:

static const HChar *s390_irgen_SLHHHR(UChar r3 __attribute__((unused)), UChar r1, UChar r2)
static const HChar *s390_irgen_SLHHLR(UChar r3 __attribute__((unused)), UChar r1, UChar r2)
Comment 2 Florian Krohm 2025-03-03 15:06:28 UTC 
Created attachment 179070 [details]
Fix IR generation for S[L]HHHR and S[L]HHLR insns

Operands were mixed up. Obvious fix.
Comment 3 Florian Krohm 2025-03-22 18:57:46 UTC 
Fixed in 165681b33af3a97338781f57da531c2d22885c02