Bug 498037 - s390x: add disassembly checker
Summary: s390x: add disassembly checker
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Florian Krohm
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-29 20:36 UTC by Florian Krohm
Modified: 2025-03-06 17:49 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch to add disasm-test (134.94 KB, patch)
2024-12-29 20:37 UTC, Florian Krohm
Details
patch to add disasm-test v2 (89.75 KB, patch)
2025-01-16 22:58 UTC, Florian Krohm
Details
fix EXTRA_DIST (89.77 KB, patch)
2025-03-01 20:19 UTC, Florian Krohm
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Krohm 2024-12-29 20:36:38 UTC
Add program disasm-test to check that s390_disasm generates the same disassembly for a given insn than objdump -d does.
This program resides in the new directory none/tests/s390x/disasm-test
The patch contains the source code, configury and makefile mods for building it and regression test integration.
There is comprehensive documentation in the README file.
The regression test will fail because https://bugs.kde.org/show_bug.cgi?id=495817 hasn't been fixed yet.
Comment 1 Florian Krohm 2024-12-29 20:37:46 UTC
Created attachment 176962 [details]
patch to add disasm-test
Comment 2 Florian Krohm 2025-01-16 22:58:40 UTC
Created attachment 177446 [details]
patch to add disasm-test v2

Bug fixes.  Regression test is made to succeed for now.
Add support for D(L,B) und D(V,B).
All vector opcodes added and reordered so as to match the order in POP.
That makes proof-reading a lot simpler.
Comment 3 Florian Krohm 2025-03-01 20:19:29 UTC
Created attachment 179020 [details]
fix EXTRA_DIST

Rats.. I forgot to add a file to EXTRA_DIST... Now fixed.

Note to self: change Makefile.am such that post-regtest-checks run as part of a regular "make". Won't delay the build much.
Comment 4 Florian Krohm 2025-03-06 17:49:26 UTC
Fixed in b98855efc89a402357469fbde06912a3bc0b0bfd