Bug 497874 - Prompt to change KWallet password after changing user password is easy to miss
Summary: Prompt to change KWallet password after changing user password is easy to miss
Status: CONFIRMED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_users (other bugs)
Version First Reported In: 6.2.5
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2024-12-24 22:35 UTC by Akseli Lahtinen
Modified: 2025-01-14 11:05 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Akseli Lahtinen 2024-12-24 22:35:48 UTC
SUMMARY

When user changes their password from System Settings -> Users -> Change password, this password is not
updated to the KWallet.

This then causes confusion for the user when they change their user password, but KWallet asks for the old one.

STEPS TO REPRODUCE
1. Change user password from system settings
2. Log out and log back in
3. Do anything that requires opening kwallet (for example, connect to wifi which user has saved to system)

OBSERVED RESULT
Kwalletmanager pops up, asking for the *old* password, not the new one user just set.

EXPECTED RESULT
Kwalletmanager would have the password updated as well and there would not be any popups


SOFTWARE/OS VERSIONS
Operating System: Fedora Linux 41
KDE Plasma Version: 6.2.4
KDE Frameworks Version: 6.9.0
Qt Version: 6.8.1
Kernel Version: 6.12.5-200.fc41.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 12 × AMD Ryzen 5 3600 6-Core Processor
Memory: 15,5 GiB of RAM
Graphics Processor: AMD Radeon RX 6600
Comment 1 Nate Graham 2025-01-02 15:14:07 UTC
Changing your password from the users KCM prompts you to change your KWallet password to match the new user password; it doesn't do it automatically though, but it definitely asks you to do it. Can you verify this or attach a screen recording showing it not happening as expected?
Comment 2 Akseli Lahtinen 2025-01-02 20:30:02 UTC
I will check properly how it shows up when I can, I created this bug on behalf of my friend who had this issue. Apparently they just got the popup to login to KWallet. 

There's possibility they just missed the popup, or misread it.
Comment 3 Nate Graham 2025-01-02 20:33:19 UTC
> Apparently they just got the popup to login to KWallet. 
Ok, that would suggest that they didn't actually have KWallet set up in the first place. Was this by any chance on a Steam Deck?
Comment 4 Akseli Lahtinen 2025-01-03 01:17:53 UTC
It's a regular Fedora 41 KDE  installation
Comment 5 Akseli Lahtinen 2025-01-03 01:18:35 UTC
Submitted too early.

It's a regular Fedora 41 KDE installation on a laptop. Thinkpad x270 to be exact.
Comment 6 Nate Graham 2025-01-03 17:17:22 UTC
Can you have them change their password again using the Users KCM, and see if, at the end of the process, it does prompt them to change their KWallet password as well?
Comment 7 Akseli Lahtinen 2025-01-13 10:02:27 UTC
What likely happened here is that the modal dialog popped up, but they closed the settings before they saw it, or clicked outside of the dialog box, which closes it immediately and thus did not notice it.

So this is more likely an UX bug than anything more nefarious.
Comment 8 Nate Graham 2025-01-13 17:25:46 UTC
Probably. I can see a few options here:
1. Make the dialog not close automatically when clicking in the darkened background area
2. Port the dialog to be an older-style separate window QtWidgets message box
3. Automatically change the wallet password if it's the same as the old user password.

#1 is easy to change, but would make the dialog inconsistent with other in-window Kirigami dialogs for now. Also, it might end up being undone anyway once we make all these dialogs be separate windows.

#2 re-introduces a QwWidgets dependency which isn't ideal for Plasma Mobile.

#3 is the ideal solution, but I don't know if it's feasible.
Comment 9 David Edmundson 2025-01-14 11:05:31 UTC
>#3 is the ideal solution, but I don't know if it's feasible.

Conceptually yes, but it would require kwalletdaemon to *not* be a GUI application. Which is basically a complete rewrite of kwallet-daemon.
This hopefully can happen with the new abstraction layer on top of kwallet.