Bug 497642 - Edit metadata plugin don't allow you to edit metadata of the selected image from Showfoto.
Summary: Edit metadata plugin don't allow you to edit metadata of the selected image f...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Showfoto-Plugins (show other bugs)
Version: 8.5.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-18 07:50 UTC by Duns
Modified: 2024-12-19 13:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.6.0
Sentry Crash Report:


Attachments
you can see that I can edit metadta of another image than the selected one (270.39 KB, image/jpeg)
2024-12-18 07:50 UTC, Duns
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Duns 2024-12-18 07:50:22 UTC
Created attachment 176740 [details]
you can see that I can edit metadta of another image than the selected one

SUMMARY

edit metadata don't allow you to edit metadata of the _current_ image

STEPS TO REPRODUCE
1. open Showfoto and select an image
2. open tools -> edit metadata
3. you are promt to edit metadata not of the current image

OBSERVED RESULT

you can't edit metadata of the current image, but of another, and you have to slide many images before to reach the desired one

EXPECTED RESULT

you should be able to edit metadata of the current image, the image shown in the main section of the window

SOFTWARE/OS VERSIONS

Operating System: KDE neon 6.2
KDE Plasma Version: 6.2.4
KDE Frameworks Version: 6.9.0
Qt Version: 6.8.1
Kernel Version: 6.8.0-51-generic (64-bit)
Graphics Platform: X11
Processors: 16 × AMD Ryzen 7 5700G with Radeon Graphics
Memory: 13,5 GiB of RAM
Graphics Processor: AMD Radeon Graphics

ADDITIONAL INFORMATION
Comment 1 Duns 2024-12-18 07:59:30 UTC
I add that in Digikam you can correctly edit metadata of the selected image, with a pop-up window very similar to the poop-up of Showfoto. So why in Digikam yes, and in Showfoto no? I guess that it should be quite easy to "export" in Showfoto what is already correctly working in Digikam...
Comment 2 caulier.gilles 2024-12-18 09:08:55 UTC
Metadata Editor is the same plugin shared between digiKam and Showfoto.

The only difference is the plugin interface used by the tool to dialog with the host application.

It sound s like a bug in the Showfoto Interface.
Comment 3 Duns 2024-12-18 09:20:46 UTC
Yes, I think so. The interface seems absolutely identical, from a graphical point of view. It would be good to fix this, because Showfoto is faster than Digikam (and its aims are a bit different, isn't it?)
Comment 4 caulier.gilles 2024-12-18 10:24:09 UTC
I don't talk the GUI interface but the C++ interface for the plugins to access to the data from the host application:

https://invent.kde.org/graphics/digikam/-/blob/master/core/libs/dplugins/iface/dmetainfoiface.cpp?ref_type=heads
Comment 5 Maik Qualmann 2024-12-18 14:35:13 UTC
In principle, the behavior is normal for this tool. We also pass the complete selection in digiKam and start with the first item. That's why the tool also has forward and back buttons. This is not possible with showFoto, there is no option to limit the selected images, the complete directory is always passed. If we only reduce it to the current image, this could disturb other users, or possibly tools that also need the entire directory (Print Tool, etc.).

Maik
Comment 6 caulier.gilles 2024-12-18 15:05:17 UTC
Maik, perhaps i miss-understood the report, but i thinking that Duns can edit all other files selected from Showfoto stack but not the current one selected....
Comment 7 Duns 2024-12-18 15:11:14 UTC
No, Gilles: probably I should be able to edit it, but after a long and annoying research (sliding many, many other images).
I don't have the technical knowledge you have, so I accept your anwers, and I an grateful for this very useful and beautiful tool. If possible, in the future, it would be nice if even with showfoto (at least with less options than in digikam) be able to edit easily metadata.
Comment 8 Maik Qualmann 2024-12-18 19:49:34 UTC
@ Gilles, we read the selected items in the Metadata Tool via the interface and start with the first item (iterator begin of list)
If I only select one item in digiKam, it is logically the first one.
In showFoto we have no items to select, so the current folder is used, starting with the first item.
There are the forward and back buttons at the bottom of the window, so you can go to any item. That's why there is also a thumbnail preview in the tool.

Alternatively, we could pass a current URL and set the list iterator to it. At the moment I don't know if the interface already knows the current URL, but I think we already have this function. I'll take a look at it.

Maik
Comment 9 Maik Qualmann 2024-12-19 07:14:18 UTC
Git commit c63c8b9c1e5ad78984665a284167f817e8c3dd1d by Maik Qualmann.
Committed on 19/12/2024 at 07:13.
Pushed by mqualmann into branch 'master'.

use active item Url as start Url in Metadata Tool in Showfoto
FIXED-IN: 8.6.0

M  +1    -1    NEWS
M  +15   -0    core/dplugins/generic/metadata/metadataedit/dialog/metadataeditdialog.cpp
M  +5    -0    core/libs/dplugins/iface/dinfointerface.cpp
M  +1    -0    core/libs/dplugins/iface/dinfointerface.h
M  +11   -2    core/libs/dplugins/iface/dmetainfoiface.cpp
M  +4    -1    core/libs/dplugins/iface/dmetainfoiface.h
M  +3    -1    core/showfoto/main/showfoto.cpp
M  +4    -2    core/showfoto/main/showfotoinfoiface.cpp
M  +2    -1    core/showfoto/main/showfotoinfoiface.h

https://invent.kde.org/graphics/digikam/-/commit/c63c8b9c1e5ad78984665a284167f817e8c3dd1d
Comment 10 Duns 2024-12-19 08:28:42 UTC
This means that in the next release of Showfoto this problem will be fixed?
Comment 11 caulier.gilles 2024-12-19 10:39:24 UTC
yes, and already verifiable on the 8.6.0 pre-release bundles available this week end at :

https://files.kde.org/digikam/
Comment 12 Duns 2024-12-19 12:38:46 UTC
very good, thank you. Altough I see only digikam, and not showfoto at the link you have provided
Comment 13 Duns 2024-12-19 12:39:21 UTC
ah, sorry: this week end ...
Comment 14 caulier.gilles 2024-12-19 13:33:27 UTC
showfoto is also included in Linux AppImage bundle. It can be started at CLI :


Linux universal AppImage bundles:
---------------------------------

* digiKam-version-timestamp-Qtversion-x86-64.appimage        => for Linux 64 bits.
* digiKam-version-timestamp-Qtversion-x86-64-debug.appimage  => for Linux 64 bits with debug symbols.

These bundles are compatible with all Linux distributions which support Fuse file system.
It must be runnable on all distributions older than 3/4 years.

Make file executable and run it as well. Nothing is installed and do not require root rights.
See here for details : http://askubuntu.com/questions/774490/what-is-an-appimage-how-do-i-install-it

Bundle executable can take arguments to run:

 without option       : run digiKam.
 <showfoto>           : run Showfoto instead digiKam.
 <debug>              : run digiKam into GDB (only suitable with appimage compiled with debug symbols).
 <debug> <showfoto>   : run Showfoto into GDB  (only suitable with appimage compiled with debug symbols).
 <help>               : show these information.

Gilles Caulier