Bug 497446 - Video seek timeline/scrubber is unusable in slideshow mode
Summary: Video seek timeline/scrubber is unusable in slideshow mode
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-SlideShow (other bugs)
Version First Reported In: 8.5.0
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-14 09:34 UTC by Curiositas Felis
Modified: 2024-12-14 23:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 8.6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Curiositas Felis 2024-12-14 09:34:45 UTC
SUMMARY
When I launch a slideshow in an album, the scrubber/video timeline seek tool visible at the top of the screen is completely unusable, along with the volume control next to it. On clicking anywhere on the timeline, we immediately advance to the next slide instead of seeking to that position. As far as I'm aware, there is also no keyboard shortcut to seek, so basically it's impossible to seek videos in the slideshow mode. 

STEPS TO REPRODUCE
1. Start a slideshow in an album which contains some videos, either by pressing F9 or going to the View > Slideshow > Play all menu
2. Try to seek the video by using the timeline control on the top of the screen

OBSERVED RESULT
The slideshow immediately advances to the next image/video in the albu

EXPECTED RESULT
The video moves to the position clicked on in the scrubber, exactly as it does when you click on it in the preview mode or any other video player. 

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
(available in the Info Center app, or by running `kinfo` in a terminal window)
Linux/KDE Plasma: Arch 6.12.4-zen1-1-zen
KDE Plasma Version: 6.2.4
KDE Frameworks Version: 6.8.0
Qt Version: 6.8.1

ADDITIONAL INFORMATION
Running on Wayland on nvidia-open drivers for RTX 4090. Phonon settings lists VLC as the preferred backend, with GStreamer as secondary. I've tried to switch those around, but it doesn't seem to change anything. I'm running on a 4K monitor (3840x2160 resolution).
Comment 1 Maik Qualmann 2024-12-14 12:03:36 UTC
In fact, the timeline in the slideshow is just an indicator and is meant to show where we are in the video at the moment. I'll change it to a wish bug entry.

Maik
Comment 2 caulier.gilles 2024-12-14 12:05:02 UTC
Hi Maik,

The slideshow timeline slider is in read-only ?

Gilles
Comment 3 Maik Qualmann 2024-12-14 12:07:07 UTC
Hi Gilles,

Yes, actually. There is no signal/connection to choose another position. But I have already started...

Maik
Comment 4 Maik Qualmann 2024-12-14 12:11:48 UTC
Sorry, I made a mistake, there is a connection from the slider...

Maik
Comment 5 Maik Qualmann 2024-12-14 20:36:41 UTC
Git commit 03aa20a2a37d3527d61eb77f0505354d75ca0cae by Maik Qualmann.
Committed on 14/12/2024 at 20:35.
Pushed by mqualmann into branch 'master'.

the video slider has to be part of the OSD screen,
since the OSD screen is transparent over all widgets.
Qt5 will still be broken, I will try to adapt it.

M  +25   -9    core/dplugins/generic/view/slideshow/common/slideshowloader.cpp
M  +109  -16   core/dplugins/generic/view/slideshow/widgets/slideosd.cpp
M  +13   -1    core/dplugins/generic/view/slideshow/widgets/slideosd.h
M  +8    -103  core/libs/video/player/qtmm/slidevideo.cpp
M  +6    -6    core/libs/video/player/qtmm/slidevideo.h

https://invent.kde.org/graphics/digikam/-/commit/03aa20a2a37d3527d61eb77f0505354d75ca0cae
Comment 6 Maik Qualmann 2024-12-14 20:53:13 UTC
Git commit 77816c672c0daa2e29243bb9772e9a7572c4fb58 by Maik Qualmann.
Committed on 14/12/2024 at 20:52.
Pushed by mqualmann into branch 'master'.

adapt Qt5 video slideshow to current code
Compilation not tested.
FIXED-IN: 8.6.0

M  +1    -1    NEWS
M  +10   -104  core/libs/video/player/QtAVPlayer/slidevideo.cpp
M  +6    -7    core/libs/video/player/QtAVPlayer/slidevideo.h

https://invent.kde.org/graphics/digikam/-/commit/77816c672c0daa2e29243bb9772e9a7572c4fb58
Comment 7 Curiositas Felis 2024-12-14 23:08:37 UTC
That was a quick fix, thank you so much!