Bug 497372 - [24.12.0 Regression] Overlay icons have inconsistent sizes
Summary: [24.12.0 Regression] Overlay icons have inconsistent sizes
Status: REPORTED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 24.12.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-12 15:58 UTC by Luke Horwell
Modified: 2024-12-20 11:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Changing view scale in Dolphin 24.12 (left) and Dolphin 24.08.3 (right) (264.81 KB, video/mp4)
2024-12-12 15:58 UTC, Luke Horwell
Details
Screenshot showing inconsistency on hidden files with Git plugin (41.07 KB, image/jpeg)
2024-12-20 11:42 UTC, Luke Horwell
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Horwell 2024-12-12 15:58:12 UTC
Created attachment 176558 [details]
Changing view scale in Dolphin 24.12 (left) and Dolphin 24.08.3 (right)

SUMMARY

After updating to Dolphin 24.12.0, overlay icons (such as symlinks and read-only) are proportionately larger at the default 64 pixels zoom compared to Dolphin 24.08.3. They no longer scale proportionately when increasing/decreasing zoom level.

These overlay icons seem to using the 22px version of the icon (e.g. "22/emblem-symbolic-link.svg"), even though the icon scheme provides a 24px size, which goes unused.

I believe it's a bug rather than an intentional design change. Attached is a video to demonstrate.


STEPS TO REPRODUCE
1. Open a folder containing files/folders which trigger an overlay icon (e.g. a symlink file)
2. Change the zoom of the view (mouse+scroll wheel)

OBSERVED RESULT
Overlay icons are larger.

EXPECTED RESULT
Overlay icons were a little smaller.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 6.2.4
KDE Frameworks Version: 6.8.0
Qt Version: 6.8.1

ADDITIONAL INFORMATION

From the 24.12.0 release notes, the closest thing could be:
"Port from KIconLoader::drawOverlays to KIconUtils::addOverlays."
http://commits.kde.org/dolphin/cebcf8dbb3ff310aa0761ad452e4ca79278d7831https://kde.org/announcements/changelogs/gear/24.12.0/
Comment 1 Luke Horwell 2024-12-14 16:52:43 UTC
Just to note, it seems to only affect the right overlay icon (e.g. emblem-symbolic-link, emblem-readonly). The left overlay icon scales as expected like the previous version (e.g. version control status: vcs-normal, vcs-locally-modified-unstaged, etc).
Comment 2 Luke Horwell 2024-12-20 11:42:00 UTC
Created attachment 176786 [details]
Screenshot showing inconsistency on hidden files with Git plugin

Looks like the left icon is indeed affected. I was going to open a new report, but it seems too similar to this one.

Overlay icons added by the Git plugin are inconsistently sized between hidden and non-hidden files and folders in Dolphin 24.12.

STEPS TO REPRODUCE
1. Create a directory and run "git init" inside.
2. Create files and folders, with some hidden by prefixing a dot in the name.
3. Commit the changes, e.g. "git add ." and "git commit -m Test".
4. Show hidden files in the folder.
5. Observe the overlay VCS icon size.

Hidden files/folders have a smaller VCS icon then non-hidden files/folders.