Bug 497253 - Wallpaper image list shows overlapping EXIF info
Summary: Wallpaper image list shows overlapping EXIF info
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image & Slideshow wallpaper plugins (show other bugs)
Version: 6.2.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-09 23:09 UTC by Frank Steinmetzger
Modified: 2024-12-17 15:14 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.10
Sentry Crash Report:


Attachments
screenshot (216.45 KB, image/png)
2024-12-09 23:09 UTC, Frank Steinmetzger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Steinmetzger 2024-12-09 23:09:37 UTC
Created attachment 176474 [details]
screenshot

SUMMARY
I have a few space photos from space agencies in my wallpaper collection. Those images tend to contain long captions and descriptions in the EXIF metadata. I just noticed that the KCM tries to display them and embarrasses itself in the process. ;-)

STEPS TO REPRODUCE
1. Open wallpaper KCM
2. Add a few images with EXIF descriptions in them
3. Enjoy

OBSERVED RESULT
Exif data floods the view.

EXPECTED RESULT
The image list should only display filenames. I guess the copyright notice would still be OK, as can be seen on the top right in my screenshot. But nothing else.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.2.4
KDE Frameworks Version: 6.8.0
Qt Version: 6.8.1
Comment 1 Frank Steinmetzger 2024-12-09 23:12:13 UTC
Oops, “top right in my screenshot” refers to an old version of the screenshot. In the one that I attached I mean the the third row, center.
Comment 2 Marco Martin 2024-12-10 09:00:20 UTC
can you share one of those images that give problems? i can't reproduce it by writing random things in the exif
Comment 3 Marco Martin 2024-12-10 09:06:35 UTC
ok, after torturing an image enough i managed to make a reproducer:
https://notmart.org/misc/PIA04200~orig.jpg
Comment 4 Nate Graham 2024-12-10 23:11:48 UTC
Can reproduce. That's a huge amount of text to have in the metadata; probably this case was not anticipated. :)
Comment 5 Jonathan Riddell 2024-12-16 15:42:00 UTC
The text does correctly truncate with ellipsis if it is a long line but a multi line comment breaks the truncating ellipsis
Comment 6 Jonathan Riddell 2024-12-16 16:25:21 UTC
Manually setting the text and subtitle in ./wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml will cause the problem.  If you make it long text with new lines in it then the truncation does not happen.  There's nothing special done with those values so maybe a general issue in KCM.GridDelegate.
Comment 7 Nate Graham 2024-12-16 16:30:27 UTC
I suspect so, yeah.
Comment 8 Jonathan Riddell 2024-12-16 16:39:55 UTC
KCM.GridDelegate is part of KCMUtils Framework which uses Qt Quick Controls Label which has an elide property
https://doc.qt.io/qt-6/qml-qtquick-text.html#elide-prop
Comment 9 Bug Janitor Service 2024-12-16 21:12:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kcmutils/-/merge_requests/244
Comment 10 Nate Graham 2024-12-17 15:14:39 UTC
Git commit 7e99100e0523c073be42dca7c4086d70221073f2 by Nate Graham.
Committed on 17/12/2024 at 15:14.
Pushed by ngraham into branch 'master'.

GridDelegate: cap label line counts to 1

This was the intention all along, but thus far was accomplished
implicitly rather than explicitly, by limiting the total height of the
parent layout. That usually works, but can break when either of the
labels are fed a specially-crafted very long string. In such a case, the
layout breaks horribly.

This commit fixes that issue by setting the maximum line count values,
making the implicit explicit.
FIXED-IN: 6.10

M  +2    -0    src/qml/components/GridDelegate.qml

https://invent.kde.org/frameworks/kcmutils/-/commit/7e99100e0523c073be42dca7c4086d70221073f2