Version: 3.0.02.12.1 (using KDE 3.0.8 (KDE 3.1 beta2)) Installed from: compiled sources Compiler: gcc version 2.95.3 20010315 (SuSE) OS: Linux (i686) release 2.4.18-4GB When setting a breakpoint it should be visible in the editor window, on the line that has the breakpoint - it is not good enough to be able to see what lines has breakpoints in another window. (I can not find out how to enable this anyway) It should probably be "anchored" in the text as well (se Bug #6471 - not solved in gideon!)
OK, I found the option now - "Show icon border" But shouldn't that be enabled by directly when you set the first breakpoint?
Sorry to reopen this, but I'd like to suggest enabling this setting by default. It took me about 10 minutes to figure out how to set breakpoints properly and another 30 minutes to learn about the "icon border". In 99% of the IDEs out there it is a common UI pattern to click on the line number gutter to set a break point which adds a red dot there. In KDevelop this didn't work. So I looked for a different way and finally found it in the right click context menu. However, it didn't seem to do anything. The reason why I though it didn't work at first was that the line highlight is so subtle that I completely overlooked it (talking about Breeze Dark theme, with default it's a little better). Then I thought "why the heck can't I just click the gutter" and wanted to open a feature request here and finally found this issue after a long thorough search. Only then I learned about the existence of "icon border" feature or what it is supposed to do (even if I knew it, I couldn't tell what it does from the name). I therefore suggest activating this feature by default. I don't see a reason why it should be disabled. I would also suggest changing the weird pixel emoji to a conventional red dot. It's clear what a red dot means (every other IDE uses red dots) and it stands out more and is less likely to be overlooked. With the default editor theme, both line highlight and icon are more or less visible, but with dark themes, they are both really hard to see.
I agree with basically all you said. Icon border and line numbers should be enabled by default. It's ok to not have this for kate, since it is used by a lot of people to edit simple text, but for KDevelop it should just be on. The breeze icon we use for breakpoint is really bad and unsuitable, from the aesthetic (imo) point of view but especially from the recognizability -- it just doesn't fit. I'll look that we can get a dedicated "breakpoint" icon.
+1. When I did some Q&A with a KDevelop noob the missing icon border was pretty confusing to that person. When pausing the debugger you don't even get a mark for the line you're in! And yes, the Breeze icons for breakpoint + 'current line in debugger' are really unfortunate...
+1 For icons I propose: - breakpoint: "draw-donut" or "crosshairs" - current breakpoint: "sharpenimage" rotated or "draw-triangle2" "draw-donut" - https://quickgit.kde.org/?p=breeze-icons.git&a=blob&f=icons%2Factions%2F24%2Fdraw-donut.svg&o=plain "crosshairs" - https://quickgit.kde.org/?p=breeze-icons.git&a=blob&f=icons%2Factions%2F22%2Fcrosshairs.svg&o=plain "sharpenimage" - https://quickgit.kde.org/?p=breeze-icons.git&a=blob&f=icons%2Factions%2F22%2Fsharpenimage.svg&o=plain "draw-triangle2" - https://quickgit.kde.org/?p=breeze-icons.git&a=blob&f=icons%2Factions%2F22%2Fdraw-triangle2.svg&o=plain
No, that is making the exact same mistake again: you use an icon with an unrelated semantic name just because it looks ok in the theme you assume. "sharpen image" might be something completely unsuitable in a different theme (e.g. oxygen). Either we get a dedicated icon called "breakpoint.svg" in breeze, or we ship our own, which is what I suggest in https://phabricator.kde.org/D3061. Regarding enabling the border by default, I sent a mail to kwrite-devel, I don't think we can change default options right now.
Git commit 3e4c15c9c88a4bd6c5458718cb917882da9b097f by Sven Brauch. Committed on 16/10/2016 at 10:36. Pushed by brauch into branch '5.0'. Do not use "script-error" icon for breakpoints It just doesn't look right for some themes, e.g. Breeze. Instead, we ship our own icon, which looks like what people expect (red dot). At this occasion, use 16x16 size for the icon border icon, because the width of the icon border is fixed to that in kate. Differential Revision: https://phabricator.kde.org/D3061 M +4 -4 debugger/breakpoint/breakpointmodel.cpp M +1 -1 debugger/interfaces/ibreakpointcontroller.cpp A +- -- pics/16x16/actions/breakpoint.png A +- -- pics/22x22/actions/breakpoint.png M +2 -5 pics/CMakeLists.txt A +95 -0 pics/scalable/breakpoint.svg M +1 -1 shell/debugcontroller.cpp http://commits.kde.org/kdevplatform/3e4c15c9c88a4bd6c5458718cb917882da9b097f
(In reply to Sven Brauch from comment #6) > No, that is making the exact same mistake again: you use an icon with an > unrelated semantic name just because it looks ok in the theme you assume. > "sharpen image" might be something completely unsuitable in a different > theme (e.g. oxygen). > > Either we get a dedicated icon called "breakpoint.svg" in breeze, or we ship > our own, which is what I suggest in https://phabricator.kde.org/D3061. Sven, you aren't getting it. I was proposing to use that images for "breakpoint.svg" and "breakpoint-current.svg" instead of that ugly red dot you have committed which breaks all the visuals being all the other icons just colourless shapes.
Ok, sorry, I misunderstood that you wanted to copy those icons instead of just using them. I'm still in favor of using the red dot instead of some concentric circles or triangles; all IDEs in the world have been using a red dot for breakpoints in the last twenty years, so we should not break that for no reason.