Bug 496768 - Add Chart as Desktop Widget on System Monitor Overview page does not do anything
Summary: Add Chart as Desktop Widget on System Monitor Overview page does not do anything
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: 5.27.10
Platform: SteamOS Linux
: HI normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords: regression
Depends on:
Blocks: 462335
  Show dependency treegraph
 
Reported: 2024-11-27 19:32 UTC by Peter
Modified: 2025-01-15 20:50 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter 2024-11-27 19:32:57 UTC
SUMMARY

On the System Monitor overview page you can right click on an indicator, e.g. CPU %, and you will see text offering to set it as a desktop widget. Clicking on it does nothing.

STEPS TO REPRODUCE
1. Launch System Monitor
2. Right click on one of the circles, e.g. CPU %.
3. Select add chart as a desktop widget.

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
For a widget to appear on the desktop.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.12

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-11-27 19:52:34 UTC
Can confirm on current git master too.
Comment 2 David Redondo 2025-01-10 07:47:25 UTC
It works for me on on git master. Nate can you share logs of plasmashell maybe when it fails?
Comment 3 Nate Graham 2025-01-10 15:48:03 UTC
Unfortunately there is no log output from plasmashell when it fails to create a widget in this manner. :/
Comment 4 Nate Graham 2025-01-13 16:46:46 UTC
Found the problem: it gets added to the wrong containment! Widgets gets added to my secondary containment. When I have two screens, the widgets are visible there. When I unplug the screen, the widgets remain there, and newly-created widgets get added there anyway despite the fact that the containment is not visible.

peter, can you reproduce this? If you connect a second screen, do you find that it's full of system monitor widgets?
Comment 5 Bug Janitor Service 2025-01-14 07:59:24 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/334
Comment 6 David Redondo 2025-01-14 10:30:59 UTC
Git commit dda55879416db22205248806a8c684a7ea76b352 by David Redondo.
Committed on 14/01/2025 at 10:22.
Pushed by davidre into branch 'master'.

Always add widget to the first screen

desktopsForActivity can contain containments that are not active
at the moment. Instead always add it to the containment of the
first screen which is more predictable than the current behavior.
FIXED-IN: 6.3

M  +1    -2    src/page/WidgetExporter.cpp

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/dda55879416db22205248806a8c684a7ea76b352
Comment 7 David Redondo 2025-01-14 10:36:28 UTC
Git commit 750c5f8e218db946469c991dc32910c283e85cd5 by David Redondo.
Committed on 14/01/2025 at 10:31.
Pushed by davidre into branch 'Plasma/6.3'.

Always add widget to the first screen

desktopsForActivity can contain containments that are not active
at the moment. Instead always add it to the containment of the
first screen which is more predictable than the current behavior.
FIXED-IN: 6.3


(cherry picked from commit dda55879416db22205248806a8c684a7ea76b352)

Co-authored-by: David Redondo <kde@david-redondo.de>

M  +1    -2    src/page/WidgetExporter.cpp

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/750c5f8e218db946469c991dc32910c283e85cd5