Created attachment 175992 [details] Rendering errors in the "frame" A safe assert is raised when editing the handles of a mesh gradient. I am unable to reproduce it in 5.2.6, meaning it's new for 5.3. Probably related is some rendering errors of the "frame" around the vector shape in question. Steps to reproduce: 1. Create a new document 2. Add a vector layer and draw a shape (like a rectangle) 3. Set the fill to Mesh Gradient and try moving some of the handles around. 4. A warning dialog will appear: Krita has encountered an internal error: SAFE ASSERT (krita): "!m_sanityIsStarting" in file /builds/graphics/krita/libs/global/kis_signal_compressor.cpp, line 210 5. Clicking "Ignore" results in a second dialog with: SAFE ASSERT (krita): "m_timer->isActive()" in file /builds/graphics/krita/libs/global/kis_signal_compressor.cpp, line 148
Double checking, the rendering error show up in 5.2.6 but not the safe asserts.
Had a friend test this on 5.2.8 (Android only) and couldn't reproduce the safe assert. It does happen in Krita Plus 5.2.9 pre-alpha.
Git commit 0842ec2b208f4dfa9411062c7e1fdde600d8fab0 by Dmitry Kazakov. Committed on 12/12/2024 at 14:49. Pushed by dkazakov into branch 'master'. Fix an assert when modifying Mesh Gradient on a shape We shouldn't add any commands to the global undo stack in the mouse move event handler. Instead, we should accumulate the command and add it to the stack in teh very end of the operation in createCommand() method. The patch also fixes a memory leak, which caused the temporary command to leak in case when the merge-branch was taken. M +13 -0 libs/command/kis_command_utils.cpp M +9 -0 libs/command/kis_command_utils.h M +3 -8 libs/flake/tools/KoPathControlPointMoveStrategy.cpp M +3 -7 libs/flake/tools/KoPathPointMoveStrategy.cpp M +8 -10 plugins/tools/defaulttool/defaulttool/ShapeGradientEditStrategy.cpp M +11 -2 plugins/tools/defaulttool/defaulttool/ShapeMeshGradientEditStrategy.cpp https://invent.kde.org/graphics/krita/-/commit/0842ec2b208f4dfa9411062c7e1fdde600d8fab0
Git commit c924b0e4f48ae97f24a24421dbeae72de5505ba6 by Dmitry Kazakov. Committed on 12/12/2024 at 15:03. Pushed by dkazakov into branch 'krita/5.2'. Fix an assert when modifying Mesh Gradient on a shape We shouldn't add any commands to the global undo stack in the mouse move event handler. Instead, we should accumulate the command and add it to the stack in teh very end of the operation in createCommand() method. The patch also fixes a memory leak, which caused the temporary command to leak in case when the merge-branch was taken. M +13 -0 libs/command/kis_command_utils.cpp M +9 -0 libs/command/kis_command_utils.h M +3 -8 libs/flake/tools/KoPathControlPointMoveStrategy.cpp M +3 -7 libs/flake/tools/KoPathPointMoveStrategy.cpp M +8 -10 plugins/tools/defaulttool/defaulttool/ShapeGradientEditStrategy.cpp M +11 -2 plugins/tools/defaulttool/defaulttool/ShapeMeshGradientEditStrategy.cpp https://invent.kde.org/graphics/krita/-/commit/c924b0e4f48ae97f24a24421dbeae72de5505ba6