Bug 496464 - strike-through text works across lines
Summary: strike-through text works across lines
Status: RESOLVED NOT A BUG
Alias: None
Product: KleverNotes
Classification: Applications
Component: Markdown parser (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Louis Schul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-19 14:29 UTC by agilob
Modified: 2024-11-21 07:24 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
promised screenshot (38.90 KB, image/png)
2024-11-20 19:41 UTC, agilob
Details

Note You need to log in before you can comment on or make changes to this bug.
Description agilob 2024-11-19 14:29:52 UTC
SUMMARY

Make a list that contains words with hyphens like:

1. abc
2. abd-2
3. abc-3

KleverNotes is trying to put strike-through across lines between `-2` and `-3` in the next line

SOFTWARE/OS VERSIONS
KLeverNotes: 1.1.0
Comment 1 Louis Schul 2024-11-20 12:09:46 UTC
(In reply to agilob from comment #0)
> SUMMARY
> 
> Make a list that contains words with hyphens like:
> 
> 1. abc
> 2. abd-2
> 3. abc-3
> 
> KleverNotes is trying to put strike-through across lines between `-2` and
> `-3` in the next line
> 
> SOFTWARE/OS VERSIONS
> KLeverNotes: 1.1.0

I can't reproduce this bug, neither in `V1.1.0` nor in `master`.

Another thing that seems weird to me is that KleverNotes doesn't parse text between `-` as strikethrough but rather as subscript, strikethrough would be text between `~~`, I did also test this and the bug doesn't show up.

Follow up questions:
- Does it happen in the editor, the preview or both ?
- Are you using the flatpak version ?
- Which font are you using ?
- If you change your font, does the issue persist ?
Comment 2 agilob 2024-11-20 19:41:33 UTC
Strike through happens in the editor, but preview renders it strangely too.

I tried changing the font from <whateverwasthedeafault> to Hack and it still appears, then I changed it to Liberation Sans. 

In Liberation Sans there is no more strike through, but the font is still different, somehow smaller, attaching a file showing this font.

In all 3 fonts it had an effect on rendering the text in both editor and preview.

I installed klevernotes from AUR https://aur.archlinux.org/packages/klevernotes

The text I'm editing is:

```
1. Java memory regions
1.1. generally split into heap and non-heap areas
1.2 JVM native memory
1.2.1 +XX:NativeMemoryTracking=summary
1.2.2 stacks, direct-buffers,
```

Then I tried 5 different font and lines between 1.1 and 1.2.2 look different in each tested font.
Comment 3 agilob 2024-11-20 19:41:48 UTC
Created attachment 175980 [details]
promised screenshot
Comment 4 Louis Schul 2024-11-21 07:24:06 UTC
(In reply to agilob from comment #3)

I don't see any strikethrough here, only subscript text, as expected...

However the sample text you gave me reveal the true issue. KleverNotes parser work as expected considering text between `-` inside the SAME LINE of text to be subscript, it is part of KleverNotes extended syntax.


Why am I talking about the "SAME LINE" when you're clearly trying to make a list ?

Well, while the text you enter looks like a list, it is not considered to be one by the CommonMark standard.
A numbered list follow this syntax: `<number>. <text>` , nothing else. 
In your case, you sometimes have `<number>.<number>. <text>` or things like that, it is not valid and will be considered as a regular text.

I can understand that it can be annoying, but it is what it is, the spec is like that.
I had a similar issue in the past for one of my class, the workaround I used is putting the items inside an unordered list:
```
- 1. Java memory regions
- 1.1. generally split into heap and non-heap areas
- 1.2 JVM native memory
- 1.2.1 +XX:NativeMemoryTracking=summary
- 1.2.2 stacks, direct-buffers,
```

It's not perfect but it works.

I hope I was able to help !

Interresting links:
Example of strikethrough text: https://en.wikipedia.org/wiki/Strikethrough#/media/File:Striked_out_text.png
Example of subscript text: https://en.wikipedia.org/wiki/Subscript_and_superscript#/media/File:Subscript_superscript_expert.png
CommonMark spec for list: https://spec.commonmark.org/0.26/#lists
Website to test the CommonMark spec: https://spec.commonmark.org/dingus/