STEPS TO REPRODUCE 1. Ctrl+Shift+F to open the find panel. 2. Select 'In Folder'. 3. enter a folder and search term for which there should be at least one match. 4. Click 'Search'. OBSERVED RESULT The search results panel is completely blank. EXPECTED RESULT The panel should contain rows such as 'One match found in folder ...'. SOFTWARE/OS VERSIONS This occurs in Kate versions 25.03.70 and 24.11.80. Version 24.08.3 is unaffected, the same search works fine in this version. Windows: 10 (build 19045.4170)
@Christoph could it be a regression from https://bugs.kde.org/show_bug.cgi?id=474461 ? Can't see any other commits in recent history that would affect search plugin
Mnnn, not sure how that should do that.
We could try toLocalFile() there instead path().
Git commit c1e55817d61ac2dface562ad5e503b5f6c5a5006 by Christoph Cullmann. Committed on 16/11/2024 at 15:31. Pushed by cullmann into branch 'master'. try to properly use toLocalFile for local files Related: bug 474461 M +1 -11 addons/search/MatchModel.cpp M +1 -1 addons/search/SearchPlugin.cpp https://invent.kde.org/utilities/kate/-/commit/c1e55817d61ac2dface562ad5e503b5f6c5a5006
(In reply to Christoph Cullmann from comment #4) > Git commit c1e55817d61ac2dface562ad5e503b5f6c5a5006 by Christoph Cullmann. I tested the new build with this change and it seems to have solved the issue.
Git commit 243168b47089a824b42d94d20284992e405bf2ff by Waqar Ahmed, on behalf of Christoph Cullmann. Committed on 17/11/2024 at 08:06. Pushed by waqar into branch 'release/24.12'. try to properly use toLocalFile for local files Related: bug 474461 (cherry picked from commit c1e55817d61ac2dface562ad5e503b5f6c5a5006) M +1 -11 addons/search/MatchModel.cpp M +1 -1 addons/search/SearchPlugin.cpp https://invent.kde.org/utilities/kate/-/commit/243168b47089a824b42d94d20284992e405bf2ff
(In reply to Cluttery from comment #5) > (In reply to Christoph Cullmann from comment #4) > > Git commit c1e55817d61ac2dface562ad5e503b5f6c5a5006 by Christoph Cullmann. > > I tested the new build with this change and it seems to have solved the > issue. Thanks!