Bug 496189 - External Audio Encoder not saved
Summary: External Audio Encoder not saved
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: Plugins (show other bugs)
Version: 24.08.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: k3b developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-12 19:44 UTC by Samuel Gilbert
Modified: 2024-11-27 23:38 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot of the empty K3b External Audio Encoder dialog (57.40 KB, image/png)
2024-11-12 19:44 UTC, Samuel Gilbert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Gilbert 2024-11-12 19:44:04 UTC
Created attachment 175769 [details]
Screenshot of the empty K3b External Audio Encoder dialog

SUMMARY

The K3b external audio encoder list is always empty and changes are not saved.

STEPS TO REPRODUCE
1. Insert an audio CD in the drive
2. Launch k3b
3. Click on the drive/audio CD in the left panel
4. Click the "Star Ripping" button in the tool bar
5. Click on the little setting button (with the "Configure Plugin" tool-tip) right of the Filetype combo-box
6. Click "Restore defaults"
7. Edit the command line of one of the formats and click OK in the edit dialog
8. Click "OK" in the K3b External Audio Encoder dialog
9. Click on the "Configure Plugin" button again

OBSERVED RESULT

The K3b External Audio Encoder dialog is empty and nothing was saved

EXPECTED RESULT

A list of the configured encoders with any changes done to their command lines saved

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:  Arch Linux (updated on 2024-11-12)
KDE Plasma Version: 6.2.3
KDE Frameworks Version: 6.8.0
Qt Version: 6.8.0

ADDITIONAL INFORMATION

Broken since at least 6 months
Comment 1 Bug Janitor Service 2024-11-20 23:37:45 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/k3b/-/merge_requests/70
Comment 2 Albert Astals Cid 2024-11-27 23:33:08 UTC
Git commit c09ec0028f4915fc70a8438c6aca2b57fd517f22 by Albert Astals Cid.
Committed on 27/11/2024 at 23:28.
Pushed by aacid into branch 'master'.

Load the settings values when showing the settings dialog

M  +1    -0    libk3b/plugin/k3bpluginmanager.cpp

https://invent.kde.org/multimedia/k3b/-/commit/c09ec0028f4915fc70a8438c6aca2b57fd517f22
Comment 3 Albert Astals Cid 2024-11-27 23:38:47 UTC
Git commit a099a601d1f51e35b2095675cbbfbe9dd5889415 by Albert Astals Cid.
Committed on 27/11/2024 at 23:38.
Pushed by aacid into branch 'release/24.12'.

Load the settings values when showing the settings dialog
(cherry picked from commit c09ec0028f4915fc70a8438c6aca2b57fd517f22)

M  +1    -0    libk3b/plugin/k3bpluginmanager.cpp

https://invent.kde.org/multimedia/k3b/-/commit/a099a601d1f51e35b2095675cbbfbe9dd5889415