Bug 495996 - Pull to refresh
Summary: Pull to refresh
Status: CONFIRMED
Alias: None
Product: Tokodon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Android Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
: 467724 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-11-09 02:48 UTC by Joshua Goins
Modified: 2025-01-20 01:07 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Goins 2024-11-09 02:48:23 UTC
***
If you're not sure this is actually a bug, instead post about it at https://discuss.kde.org

If you're reporting a crash, attach a backtrace with debug symbols; see https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports

Please remove this comment after reading and before submitting - thanks!
***



SUMMARY


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
(available in the Info Center app, or by running `kinfo` in a terminal window)
Linux/KDE Plasma: 
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Title
Comment 1 Joshua Goins 2024-11-27 21:10:26 UTC
*** Bug 467724 has been marked as a duplicate of this bug. ***
Comment 2 Bug Janitor Service 2025-01-20 00:34:11 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/tokodon/-/merge_requests/693
Comment 3 Joshua Goins 2025-01-20 01:07:14 UTC
Git commit 8ec7279b9771cf1aa5701704e7795cc3c7d41b17 by Joshua Goins.
Committed on 20/01/2025 at 01:01.
Pushed by redstrate into branch 'master'.

Improve refreshing the main timeline, other misc fixes

Currently refreshing the main timeline involves throwing everything away
and starting fresh, but we don't need to do that. Now we use the
pagination to load all newer posts, and we're a bit smarter about it
too.

An additional bug that I think I fixed is receiving duplicate posts. Now
fetchedTimeline and handleEvent shouldn't add posts we have already.

A bug that I ran into but not sure if it's ever resulted in a crash is
not checking if posts is empty before calling first() on it, but good to
fix anyway.
Related: bug 477420

M  +1    -1    src/autotests/data/status-poll.json
M  +10   -4    src/autotests/timelinetest.cpp
M  +30   -11   src/timeline/maintimelinemodel.cpp
M  +15   -0    src/timeline/timelinemodel.cpp

https://invent.kde.org/network/tokodon/-/commit/8ec7279b9771cf1aa5701704e7795cc3c7d41b17